Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PojoResourceTest due to issue on Yasson 3.0.1 #27618

Merged
merged 1 commit into from Aug 31, 2022

Conversation

loicmathieu
Copy link
Contributor

@loicmathieu loicmathieu commented Aug 31, 2022

Fixes #27506

Disable test that fails in Jakarata EE migration due to Yasson 3.0.1 bug eclipse-ee4j/yasson#575
An issue has been openned to remember to re-enable it in the future see #27619

@loicmathieu loicmathieu marked this pull request as ready for review August 31, 2022 08:51
@loicmathieu loicmathieu requested a review from gsmet August 31, 2022 08:51
@gsmet
Copy link
Member

gsmet commented Aug 31, 2022

@loicmathieu I'm not sure I understand the issue you created. You created an issue for serialization of null Optionals but I see you're defining a value here?
And... if it's just an issue with null optionals, maybe we can simply define a value where it's missing?

@loicmathieu
Copy link
Contributor Author

I'll check what's going on, I think the same issue occurs when deserializing and that causes some issue somewhere. I'll switch to the jakarta rewrite branch and test again to have the exact exception.

@loicmathieu
Copy link
Contributor Author

@gsmet maybe there is also an issue with Optional serialization but when I test manually the endpoint what fails is serialization not deserialization. Let's disable the test and see what they have to say at Yasson side, when/if they provide a fix I'll re-enable the test and see if more issue exist.

@gsmet
Copy link
Member

gsmet commented Aug 31, 2022

Well my problem is that you opened an issue about null optionals and in the test you are pushing a value. That's what I don't understand.

@gsmet
Copy link
Member

gsmet commented Aug 31, 2022

To clarify: I want to make sure we reported the issue properly.

@loicmathieu
Copy link
Contributor Author

In fact, deserialization of Optional didn't seems to work either, it leads to a null value in database that why the serialization throws a NPE.

As the provided test have both serialization and deserialization, they may fix both (or as I said, I'll work with them to fix that).

@gsmet gsmet merged commit 85924a0 into quarkusio:main Aug 31, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Aug 31, 2022
@gsmet
Copy link
Member

gsmet commented Aug 31, 2022

OK, thanks!

@loicmathieu loicmathieu deleted the disable-optional-it branch August 31, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jakarta - EE 9 - Serialization issue in MongoDB IT PojoResourceTest
2 participants