Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: how to lock with Panache #2788

Merged
merged 1 commit into from Jun 19, 2019

Conversation

loicmathieu
Copy link
Contributor

Add to the Panache guide how to implement a JPA lock with Panache.

This document the workaround to lock management waiting for a potential more high level solution for which no developement has been decided yet, there is ongoing discussion here: #2744 .

I inject the EntityManager with the @Inject annotation and not the @PersistenceContext one, I'm not very familiar with JPA and this works in a PanacheRepository but I don't know if it's the correct way to inject it.

@loicmathieu loicmathieu force-pushed the feat/document_jpa_lock branch 2 times, most recently from c4f29a9 to fe7b929 Compare June 11, 2019 13:10
@cescoffier cescoffier requested a review from FroMage June 11, 2019 14:48
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good, aside from some minor typos.

docs/src/main/asciidoc/hibernate-orm-panache-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/hibernate-orm-panache-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/hibernate-orm-panache-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/hibernate-orm-panache-guide.adoc Outdated Show resolved Hide resolved
How to implement a JPA lock with Panache
@loicmathieu
Copy link
Contributor Author

@FroMage the documentation is updated as you suggested. ready to go ;)

@FroMage FroMage merged commit 5d03b07 into quarkusio:master Jun 19, 2019
@FroMage
Copy link
Member

FroMage commented Jun 19, 2019

Sorry about the delay, thanks!

@FroMage FroMage added this to the 0.17.0 milestone Jun 19, 2019
@loicmathieu loicmathieu deleted the feat/document_jpa_lock branch June 19, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants