Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Revert Narayana recovery manager service #28002

Closed
wants to merge 62 commits into from

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Sep 16, 2022

This is a revert of #26161 .

Please don't merge for now. We have to discuss this with @mmusgrov @zhfeng and @Sanne .

See my comment here: #26161 (comment) .

I created this PR to make sure this stays on my radar and I don't release 2.13.0.Final without this situation fixed.

dependabot bot and others added 30 commits September 9, 2022 21:09
Bumps `kafka3.version` from 3.2.1 to 3.2.2.

Updates `kafka-clients` from 3.2.1 to 3.2.2

Updates `kafka-streams` from 3.2.1 to 3.2.2

Updates `kafka-streams-test-utils` from 3.2.1 to 3.2.2

Updates `kafka_2.13` from 3.2.1 to 3.2.2

---
updated-dependencies:
- dependency-name: org.apache.kafka:kafka-clients
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.kafka:kafka-streams
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.kafka:kafka-streams-test-utils
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.kafka:kafka_2.13
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 1 to 3.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v1...v3)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…tions/download-artifact-3

Bump actions/download-artifact from 1 to 3
Update Stork version to align with k8s client 6.x
Quarkus NativeImageBuildStep fails with perm denied with docker rootless
Allow transforming the DB2 JDBC driver to Jakarta APIs during Augmentation
…ion-3.2.2

Bump kafka3.version from 3.2.1 to 3.2.2
This allows for users to configure their filters
via the usual Quarkus configuration approach.

Follows up on: #27864
The truststore password was being sent as empty ("") in the JksOptions. This caused the following exception:

```
Caused by: io.vertx.core.VertxException: java.security.UnrecoverableKeyException: Get Key failed: Given final block not properly padded. Such issues can arise if a bad key is used during decryption. 
[09:59:27.352] [INFO] [client]  at io.vertx.core.net.impl.SSLHelper.getContext(SSLHelper.java:480) 
[09:59:27.353] [INFO] [client]  at io.vertx.core.net.impl.SSLHelper.getContext(SSLHelper.java:469) 
[09:59:27.353] [INFO] [client]  at io.vertx.core.net.impl.SSLHelper.validate(SSLHelper.java:507) 
[09:59:27.353] [INFO] [client]  at io.vertx.core.net.impl.NetClientImpl.<init>(NetClientImpl.java:95) 
[09:59:27.353] [INFO] [client]  at io.vertx.core.http.impl.HttpClientImpl.<init>(HttpClientImpl.java:155) 
[09:59:27.354] [INFO] [client]  at io.vertx.core.impl.VertxImpl.createHttpClient(VertxImpl.java:338) 
[09:59:27.354] [INFO] [client]  at io.vertx.core.impl.VertxImpl.createHttpClient(VertxImpl.java:350) 
[09:59:27.354] [INFO] [client]  at org.jboss.resteasy.reactive.client.impl.ClientImpl.<init>(ClientImpl.java:170) 
[09:59:27.354] [INFO] [client]  at org.jboss.resteasy.reactive.client.impl.ClientBuilderImpl.build(ClientBuilderImpl.java:244) 
[09:59:27.354] [INFO] [client]  at io.quarkus.rest.client.reactive.runtime.RestClientBuilderImpl.build(RestClientBuilderImpl.java:332) 
[09:59:27.355] [INFO] [client]  at io.quarkus.rest.client.reactive.runtime.RestClientCDIDelegateBuilder.build(RestClientCDIDelegateBuilder.java:64) 
[09:59:27.355] [INFO] [client]  at io.quarkus.rest.client.reactive.runtime.RestClientCDIDelegateBuilder.createDelegate(RestClientCDIDelegateBuilder.java:42) 
[09:59:27.355] [INFO] [client]  at io.quarkus.rest.client.reactive.runtime.RestClientReactiveCDIWrapperBase.<init>(RestClientReactiveCDIWrapperBase.java:20) 
[09:59:27.355] [INFO] [client]  at io.jester.examples.quarkus.greetings.Client$$CDIWrapper.<init>(Unknown Source) 
[09:59:27.356] [INFO] [client]  at io.jester.examples.quarkus.greetings.Client$$CDIWrapper_ClientProxy.<init>(Unknown Source) 
[09:59:27.356] [INFO] [client]  at io.jester.examples.quarkus.greetings.Client$$CDIWrapper_Bean.proxy(Unknown Source) 
[09:59:27.356] [INFO] [client]  at io.jester.examples.quarkus.greetings.Client$$CDIWrapper_Bean.get(Unknown Source) 
[09:59:27.356] [INFO] [client]  at io.jester.examples.quarkus.greetings.Client$$CDIWrapper_Bean.get(Unknown Source) 
[09:59:27.357] [INFO] [client]  ... 26 more 
[09:59:27.357] [INFO] [client] Caused by: java.security.UnrecoverableKeyException: Get Key failed: Given final block not properly padded. Such issues can arise if a bad key is used during decryption. 
[09:59:27.357] [INFO] [client]  at java.base/sun.security.pkcs12.PKCS12KeyStore.engineGetKey(PKCS12KeyStore.java:446) 
[09:59:27.357] [INFO] [client]  at java.base/sun.security.util.KeyStoreDelegator.engineGetKey(KeyStoreDelegator.java:90) 
[09:59:27.357] [INFO] [client]  at java.base/java.security.KeyStore.getKey(KeyStore.java:1057) 
[09:59:27.357] [INFO] [client]  at io.vertx.core.net.impl.KeyStoreHelper.<init>(KeyStoreHelper.java:109) 
[09:59:27.358] [INFO] [client]  at io.vertx.core.net.KeyStoreOptionsBase.getHelper(KeyStoreOptionsBase.java:187) 
[09:59:27.358] [INFO] [client]  at io.vertx.core.net.KeyStoreOptionsBase.getTrustManagerFactory(KeyStoreOptionsBase.java:217) 
[09:59:27.358] [INFO] [client]  at io.vertx.core.net.impl.SSLHelper.getTrustMgrFactory(SSLHelper.java:327) 
[09:59:27.358] [INFO] [client]  at io.vertx.core.net.impl.SSLHelper.getContext(SSLHelper.java:478) 
[09:59:27.358] [INFO] [client]  ... 43 more 
[09:59:27.359] [INFO] [client] Caused by: javax.crypto.BadPaddingException: Given final block not properly padded. Such issues can arise if a bad key is used during decryption. 
[09:59:27.359] [INFO] [client]  at java.base/com.sun.crypto.provider.CipherCore.unpad(CipherCore.java:975) 
[09:59:27.359] [INFO] [client]  at java.base/com.sun.crypto.provider.CipherCore.fillOutputBuffer(CipherCore.java:1056) 
[09:59:27.359] [INFO] [client]  at java.base/com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:853) 
[09:59:27.359] [INFO] [client]  at java.base/com.sun.crypto.provider.PKCS12PBECipherCore.implDoFinal(PKCS12PBECipherCore.java:408) 
[09:59:27.360] [INFO] [client]  at java.base/com.sun.crypto.provider.PKCS12PBECipherCore$PBEWithSHA1AndDESede.engineDoFinal(PKCS12PBECipherCore.java:440) 
[09:59:27.360] [INFO] [client]  at java.base/javax.crypto.Cipher.doFinal(Cipher.java:2202) 
[09:59:27.360] [INFO] [client]  at java.base/sun.security.pkcs12.PKCS12KeyStore.lambda$engineGetKey$0(PKCS12KeyStore.java:387) 
[09:59:27.360] [INFO] [client]  at java.base/sun.security.pkcs12.PKCS12KeyStore$RetryWithZero.run(PKCS12KeyStore.java:283) 
[09:59:27.360] [INFO] [client]  at java.base/sun.security.pkcs12.PKCS12KeyStore.engineGetKey(PKCS12KeyStore.java:381) 
[09:59:27.361] [INFO] [client]  ... 50 more 
```
Resteasy Rest Client: Fix truststore password issue with Vert.x
Enable the registration of @LoggingFilter classes via CDI
See the issue[1] for context.
Also add a new test for this functionality.

[1] #27931
Removed unused field from LoggingSetupRecorder
Bumps [nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt) from 9.24.4 to 9.25.
- [Changelog](https://bitbucket.org/connect2id/nimbus-jose-jwt/src/master/CHANGELOG.txt)
- [Commits](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.25..9.24.4)

---
updated-dependencies:
- dependency-name: com.nimbusds:nimbus-jose-jwt
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…nism-should-challenge

Adjust 'challenge' selection so that custom auth mechanism is called
…s-nimbus-jose-jwt-9.25

Bump nimbus-jose-jwt from 9.24.4 to 9.25
@quarkus-bot quarkus-bot bot added area/graphql area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search / Elasticsearch area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/jakarta area/keycloak area/logging area/maven area/mongodb area/narayana Transactions / Narayana area/oidc area/panache area/persistence area/picocli area/platform Issues related to definition and interaction with Quarkus Platform area/reactive-messaging area/redis area/resteasy-reactive area/smallrye area/spring Issues relating to the Spring integration area/stork area/testing area/vertx labels Sep 16, 2022
@quarkus-bot quarkus-bot bot added this to To do in Quarkus Documentation Sep 16, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 16, 2022

@gsmet gsmet closed this Sep 16, 2022
Quarkus Documentation automation moved this from To do to Done Sep 16, 2022
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Sep 16, 2022
@gsmet
Copy link
Member Author

gsmet commented Sep 16, 2022

Had issues properly targeting 2.13 with the GitHub revert feature, replaced by #28003 .

@gsmet gsmet deleted the revert-26161-narayana_recovery_service branch October 4, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agroal area/arc Issue related to ARC (dependency injection) area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/funqy area/gradle Gradle area/graphql area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search / Elasticsearch area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/jakarta area/keycloak area/logging area/maven area/mongodb area/narayana Transactions / Narayana area/oidc area/panache area/persistence area/picocli area/platform Issues related to definition and interaction with Quarkus Platform area/reactive-messaging area/redis area/resteasy-reactive area/smallrye area/spring Issues relating to the Spring integration area/stork area/testing area/vertx triage/invalid This doesn't seem right
Development

Successfully merging this pull request may close these issues.

None yet