Don't merge - Revert "Improve Narayana recovery manager service and integrate it with agroal"

[gsmet]

This is a revert of #26161 .

Please don't merge for now. We have to discuss this with @mmusgrov @zhfeng and @Sanne .

See my comment here: #26161 (comment) .

I created this PR to make sure this stays on my radar and I don't release 2.13.0.Final without this situation fixed.

[quarkus-bot]

Failing Jobs - Building b5ebff1

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	Build	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 17
✔️	JVM Tests - JDK 18
⌛	MicroProfile TCKs Tests	Verify	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/oidc-code-flow 

📦 integration-tests/oidc-code-flow

✖ io.quarkus.it.keycloak.CodeFlowTest.testTokenAutoRefresh line 497 - More details - Source on GitHub

com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 401 Unauthorized for http://localhost:8081/tenant-autorefresh
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:701)
	at com.gargoylesoftware.htmlunit.WebClient.loadDownloadedResponses(WebClient.java:2452)

[mmusgrov]

I'm not sure that adding a property to disable recovery is wise. We've had this kind of request before: users want transactions but don't want the overhead of recovery, however JTA without recovery does not provide ACID guarantees so we've always resisted such requests.

I think what you really need is lazy initialisation of the recovery system when a transaction involving multiple participants starts or a property that says initialise recovery at start up. But both of these options require changes to narayana.

[zhfeng]

agroal needs to register AgroalXAResourceRecovery to XAResourceRecoveryRegistry when gernerating the DataSource at start up. So I have to say there is no need to lazy initialisation of the recovery system. Actually the issue is that RecoveryManagerService creates a directory ObjectStore at start up that is not wanted on customer side. But I think we will find a way to resolve it, see #28014 (comment)

[zhfeng]

And also if quarkus.datasource.jdbc.transaction=XA, we have to enable the recovery in narayana-jta implicty. That could be in 2.14, see #28025 (review)

[gsmet]

See #28025 for a better outcome.