Arc - register certain CDI components under BuildContext so extension… #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 for the Spring parts |
mkouba
reviewed
Jun 12, 2019
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanDeployment.java
Outdated
Show resolved
Hide resolved
|
Also, looks like I broke some other Spring bits with it, will check the failing tests in the morning. |
|
Let me know if you need any help with the Spring tests |
|
I think I found it. Looks like |
…s can use that. Modify SpringDIProcessor to make use of this.
mkouba
approved these changes
Jun 13, 2019
mkouba
added
the
triage/waiting-for-ci
geoand
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s can use that.
Modify SpringDIProcessor to make use of this.
Resolves #2188