Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more OIDC debug messages and update the refresh token test #28130

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

sberyozkin
Copy link
Member

Here is another try at chasing the refresh token test failure but also it tries to improve the way the OIDC errors are logged, here is a summary of changes:

  • the test fails with 401 instead of 200, at least as far as OIDC CodeAuthenticationMechanism is concerned it can be caused only by AuthenticationCompletionException (as opposed to AuthenticationFailedException which is a signal to challenge via a redirect, to authenticate in KC/etc) so I've updated the code to produce an error log messages in all such cases and updated/added error message
  • Use Uni.createFrom().failure instead of throw where possible
  • Reverted an earlier change I did to the way the refresh token failure is logged - since it is not a real error as far as the working application is concerned, it just means the user will have to re-authenticate instead of the ID token/session being refreshed seamlessly, so now it is again a debug log message
  • CodeFlowTest#testTokenRefresh - 3 tests in CodeFlowTest use the tenant-logout configuration and the request URI ending with tenant-logout, so it is hard to see in the build log which of these tests has produced which log messages, so I've updated this test to use a dedicated tenant-refresh tenant and URI space, and also decreased the frequency of the polling

@gsmet gsmet merged commit 782c6ba into quarkusio:main Sep 21, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 21, 2022
@sberyozkin sberyozkin deleted the more_oidc_debug_messages branch September 21, 2022 22:34
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.1.Final Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants