doc: add multi stage build to the native guide #2859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@loicmathieu Nice. Maybe add a note on the minimum required docker version to run multistage build? |
|
@machi1990 it's Docker 17.05 ... two years old, maybe it's not worth specifying it ... |
|
@gsmet Sure thing, I will check it later on tonight |
geoand
reviewed
Jun 17, 2019
geoand
reviewed
Jun 17, 2019
geoand
reviewed
Jun 17, 2019
loicmathieu
force-pushed
the
feat/document_multi_stage_build
branch
2 times, most recently
from
1a3ae56
to
a9b5c81
Compare
geoand
reviewed
Jun 18, 2019
loicmathieu
force-pushed
the
feat/document_multi_stage_build
branch
from
a9b5c81
to
f134fcd
Compare
geoand
approved these changes
Jun 18, 2019
|
The changes appear to have been made, can you re-review @gsmet ? |
loicmathieu
force-pushed
the
feat/document_multi_stage_build
branch
from
f134fcd
to
150bf14
Compare
|
Hello, I rebase on master as the native doc guide changes. |
emmanuelbernard
approved these changes
Jun 26, 2019
|
@gsmet I went ahead and merged in master, probably worth having it in 0.18? |
|
@emmanuelbernard I cherry-picked it to the 0.18 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some documentation to the native guide to show how to generate a native image using a multi-stage docker build.
It refers to this discussion : #2814