Ensure that Ryuk does not get started when simply checking for Docker #28702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually Ryuk containers started by TestContainers will be stopped, but there are cases when after a build such containers are left dangling. With this change, we ensure that Ryuk is not started when all we are doing is checking whether docker is available. Fixes: quarkusio#25852
geoand
changed the title
gsmet
reviewed
Oct 20, 2022
| boolean isAvailable = (boolean) dockerClientFactoryClass.getMethod("isDockerAvailable") | ||
| .invoke(dockerClientFactoryInstance); | ||
| if (!isAvailable) { | ||
| compressor.closeAndDumpCaptured(); | ||
| } | ||
|
|
||
| // restore the previous value | ||
| updateUserConfigMethod.invoke(configurationInstance, "testcontainers.reuse.enable", oldReusePropertyValue); |
There was a problem hiding this comment.
Shouldn't this be done in a finally block?
There was a problem hiding this comment.
Not really, because all failures happen before isDockerAvailable
This comment has been minimized.
This comment has been minimized.
gastaldi
approved these changes
Oct 20, 2022
gsmet
approved these changes
Oct 20, 2022
This was referenced Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually Ryuk containers started by TestContainers will be stopped, but there are cases when after a build such containers are left dangling.
With this change, we ensure that Ryuk is not started when all we are doing is checking whether docker is available.
Fixes: #25852