Move to GraalVM 19 #2875

dmlloyd · 2019-06-18T14:26:20Z

Fixes #2792, fixes #2412, fixes #2563, fixes #2438, fixes #2428, fixes #2410, fixes #2876.

dmlloyd · 2019-06-18T14:28:37Z

~~This is a draft because we still have a number of docs updates to do. In particular #2876 is still outstanding.~~ The docs update is now included.

core/creator/src/main/java/io/quarkus/creator/phase/nativeimage/NativeImagePhase.java

FroMage · 2019-06-18T14:35:52Z

core/deployment/src/main/java/io/quarkus/deployment/steps/SubstrateAutoFeatureStep.java

@@ -29,7 +34,17 @@

 public class SubstrateAutoFeatureStep {

-    private static final String GRAAL_AUTOFEATURE = "io.quarkus/runner/AutoFeature";
+    private static final String GRAAL_AUTOFEATURE = "io/quarkus/runner/AutoFeature";


Oh WOW, we're replacing a partly binary class name. Can we introduce a convension for constant class names that lets us know if it's a class name, or a class binary name ('.' or '/')?

TBH it's a complete mess. We have APIs that accept either one, APIs that require one or the other, and APIs that accept one and produce the other. With no documentation of course.

I know, I'm just saying we should once and for all decide on a suffix/terminology for these constants. I've the same problem in my extensions.

FroMage · 2019-06-18T14:36:55Z

core/deployment/src/main/java/io/quarkus/deployment/steps/SubstrateAutoFeatureStep.java

                            farray);
                }
            }
            CatchBlockCreator cc = tc.addCatch(Throwable.class);
-            //cc.invokeVirtualMethod(ofMethod(Throwable.class, "printStackTrace", void.class), cc.getCaughtException());
+            cc.invokeVirtualMethod(ofMethod(Throwable.class, "printStackTrace", void.class), cc.getCaughtException());


Is this meant to stay, or a debug thing that should stay commented out ?

I don't know really. It does produce an exception from Jackson. But I think that might be a legitimate problem.

dmlloyd · 2019-06-18T16:06:40Z

The native image failures are expected as CI isn't running 19.0.2 yet.

FroMage · 2019-06-19T08:20:23Z

This is waiting for @cescoffier to create a docker image.

gsmet · 2019-06-21T07:57:06Z

@dmlloyd there is a conflict now, can you rebase?
@cescoffier I think you have built an image? Could you reference its name here so that @dmlloyd can update the Azure pipelines with it?

dmlloyd · 2019-06-21T10:40:52Z

Rebased. FYI I have no idea how to do anything with the Azure pipelines; we might have to ping @n1hility for that.

gsmet · 2019-06-21T10:42:07Z

OK, I think we can take care of it. My current understanding is that changing the image would be a code update. Not yet sure if we have to update the pipelines. I'll check that on Monday once @cescoffier has prepared the image.

gsmet

@dmlloyd I added a few comments/questions. Could you take care of them?

Thanks!

bom/pom.xml

core/creator/src/main/java/io/quarkus/creator/phase/nativeimage/NativeImagePhase.java

integration-tests/kogito/javax.inject.Named

… as default policy

dmlloyd · 2019-06-21T14:03:16Z

All fixed @gsmet

…nually installed

machi1990 · 2019-06-21T18:54:23Z

I remember asking here #1602 (comment) about the FIXME.. comment in this method

quarkus/core/creator/src/main/java/io/quarkus/creator/phase/nativeimage/NativeImagePhase.java

Lines 515 to 528 in 688ee16

    
           //FIXME remove after transition period 
        
           private boolean isThisGraalVMRCObsolete() { 
        
               final String vmName = System.getProperty("java.vm.name"); 
        
               log.info("Running Quarkus native-image plugin on " + vmName); 
        
               final List<String> obsoleteGraalVmVersions = Arrays.asList("-rc9", "-rc10", "-rc11", "-rc12", "-rc13", "-rc14", 
        
                       "-rc15"); 
        
               final boolean vmVersionIsObsolete = obsoleteGraalVmVersions.stream().anyMatch(vmName::contains); 
        
               if (vmVersionIsObsolete) { 
        
                   log.error("Out of date RC build of GraalVM detected! Please upgrade to GraalVM RC16"); 
        
                   return true; 
        
               } 
        
               return false; 
        
           }

. Is this the right moment to deal with the comment?
If not, should we update the code in question to take into consideration 19.0.2?

Update the Docker image

dmlloyd · 2019-06-24T13:45:19Z

I remember asking here #1602 (comment) about the FIXME.. comment in this method

quarkus/core/creator/src/main/java/io/quarkus/creator/phase/nativeimage/NativeImagePhase.java

Lines 515 to 528 in 688ee16

//FIXME remove after transition period

private boolean isThisGraalVMRCObsolete() {

final String vmName = System.getProperty("java.vm.name");

log.info("Running Quarkus native-image plugin on " + vmName);

final List<String> obsoleteGraalVmVersions = Arrays.asList("-rc9", "-rc10", "-rc11", "-rc12", "-rc13", "-rc14",

"-rc15");

final boolean vmVersionIsObsolete = obsoleteGraalVmVersions.stream().anyMatch(vmName::contains);

if (vmVersionIsObsolete) {

log.error("Out of date RC build of GraalVM detected! Please upgrade to GraalVM RC16");

return true;

}

return false;

}

. Is this the right moment to deal with the comment?
If not, should we update the code in question to take into consideration 19.0.2?

Let's address it in a follow-up PR.

FroMage reviewed Jun 18, 2019

View reviewed changes

core/creator/src/main/java/io/quarkus/creator/phase/nativeimage/NativeImagePhase.java Show resolved Hide resolved

FroMage reviewed Jun 18, 2019

View reviewed changes

dmlloyd force-pushed the graal-19 branch from fa2c417 to a221667 Compare June 18, 2019 15:13

dmlloyd marked this pull request as ready for review June 18, 2019 15:34

gsmet added the coding-in-progress label Jun 18, 2019

gsmet added this to the 0.18.0 milestone Jun 19, 2019

Sanne added 2 commits June 21, 2019 05:37

Some MethodReplacement now obsolete

8bb206d

Method renamed in AutomaticFeature handling class initializations

7533c20

dmlloyd force-pushed the graal-19 branch from a26496d to c9f7ea0 Compare June 21, 2019 10:40

gsmet requested changes Jun 21, 2019

View reviewed changes

Sanne and others added 2 commits June 21, 2019 09:01

Temporary hardcode to return to full initialization during build time…

ff53b46

… as default policy

Method renamed in GraalVM 19

7071290

dmlloyd force-pushed the graal-19 branch from c9f7ea0 to 65f0f13 Compare June 21, 2019 14:02

dmlloyd added 6 commits June 21, 2019 09:16

Use graal-sdk 19.0.2

b0b9404

Fix wrong class punctuation

640d285

Introduce constant for RuntimeReflection class

8d62041

Change text refs in wrong package to refs in right package

e7c7dbd

Update SDK version for documentation

5205853

Update documentation to include a note that native-image has to be ma…

493e408

…nually installed

dmlloyd force-pushed the graal-19 branch from 65f0f13 to 493e408 Compare June 21, 2019 14:19

gsmet approved these changes Jun 21, 2019

View reviewed changes

dmlloyd added triage/waiting-for-ci Ready to merge when CI successfully finishes and removed coding-in-progress labels Jun 21, 2019

gsmet changed the title ~~Move to Graal 19~~ Move to GraalVM 19 Jun 21, 2019

gsmet added the release/noteworthy-feature label Jun 21, 2019

cescoffier and others added 5 commits June 24, 2019 13:41

Update the docker image to be used as builder.

4368c18

Update the GraalVM version checker

4302e0d

Fix S2I Guides to use the proper version

0530f42

Merge pull request #2 from cescoffier/graal-19

fb966c7

Update the Docker image

Merge with master to resolve trivial BOM conflict

1f5f52b

emmanuelbernard removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 24, 2019

emmanuelbernard merged commit 4e9bfd7 into quarkusio:master Jun 24, 2019

dmlloyd deleted the graal-19 branch June 24, 2019 16:36

gsmet removed the release/noteworthy-feature label Jun 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move to GraalVM 19 #2875

Move to GraalVM 19 #2875

dmlloyd commented Jun 18, 2019 •

edited

Loading

dmlloyd commented Jun 18, 2019 •

edited

Loading

FroMage Jun 18, 2019

dmlloyd Jun 18, 2019

FroMage Jun 19, 2019

FroMage Jun 18, 2019

dmlloyd Jun 18, 2019

dmlloyd commented Jun 18, 2019

FroMage commented Jun 19, 2019

gsmet commented Jun 21, 2019

dmlloyd commented Jun 21, 2019

gsmet commented Jun 21, 2019 •

edited

Loading

gsmet left a comment

dmlloyd commented Jun 21, 2019

machi1990 commented Jun 21, 2019

dmlloyd commented Jun 24, 2019

Move to GraalVM 19 #2875

Move to GraalVM 19 #2875

Conversation

dmlloyd commented Jun 18, 2019 • edited Loading

dmlloyd commented Jun 18, 2019 • edited Loading

FroMage Jun 18, 2019

Choose a reason for hiding this comment

dmlloyd Jun 18, 2019

Choose a reason for hiding this comment

FroMage Jun 19, 2019

Choose a reason for hiding this comment

FroMage Jun 18, 2019

Choose a reason for hiding this comment

dmlloyd Jun 18, 2019

Choose a reason for hiding this comment

dmlloyd commented Jun 18, 2019

FroMage commented Jun 19, 2019

gsmet commented Jun 21, 2019

dmlloyd commented Jun 21, 2019

gsmet commented Jun 21, 2019 • edited Loading

gsmet left a comment

Choose a reason for hiding this comment

dmlloyd commented Jun 21, 2019

machi1990 commented Jun 21, 2019

dmlloyd commented Jun 24, 2019

dmlloyd commented Jun 18, 2019 •

edited

Loading

dmlloyd commented Jun 18, 2019 •

edited

Loading

gsmet commented Jun 21, 2019 •

edited

Loading