New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recompose security-openid-connect-web-authentication.adoc to Diataxis framework #30518
Conversation
Good evening @sheilamjones Thanks for this PR, I'd consider naming it a Enjoy the weekend |
fde6603
to
dbec490
Compare
Hi Sheila, should this PR be combined with another PR you opened ? I'd like to see how both new files are linked to, you probably need to rebase once @michelle-purcell 's PR is merged, as the OIDC intro section will be in the new auth mechanisms doc. |
fc2219c
to
d84c154
Compare
21e1f63
to
708fe7b
Compare
@sberyozkin: Thanks for your comments above. I have renamed the new tutorial file to shorten it per your suggestions. In this PR, the Quickstart content from the original file (security-openid-connect-web-authentication.adoc) file has been removed from there and recomposed into this new tutorial file. I also rebased to pull in Michelle's latest changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work.
docs/src/main/asciidoc/security-oidc-protect-web-application-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-protect-web-application-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-protect-web-application-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-protect-web-application-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-protect-web-application-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-protect-web-application-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-web-authentication.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sheilamjones - Nice job 👍 Just a few very minor comments.
Some might be slightly outside the scope of this iteration.
708fe7b
to
ffca4e9
Compare
🙈 The PR is closed and the preview is expired. |
Thanks for the updates, My question is, should #30456 and this PR become a single PR ? Both PR affect the same document, and it is not easy to see how this single |
Thanks @sberyozkin. I shall close PR #30456 and move those changes under this single PR. |
ffca4e9
to
5f254de
Compare
docs/src/main/asciidoc/security-authentication-mechanisms-concept.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-protect-web-application-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-web-authentication-concept.adoc.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-web-authentication.adoc
Outdated
Show resolved
Hide resolved
|
||
Congratulations! | ||
You have learned how to set up and use the OIDC authorization code flow mechanism to protect and test application HTTP endpoints. | ||
After you have completed this tutorial, explore some of the other security mechanisms in Quarkus. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the line 249 is not necessary, and the link to the bearer token concept should be in References, as well as the security concept one.
As far as the next steps in scope of this tutorial is concerned, it should be the web-app reference (concept) and OIDC multi-tenency
5f254de
to
22f8e11
Compare
Good evening @sheilamjones :-), thanks for this PR, a lot of work has been done here which is very appreciated. |
By the way, Sheila, your idea to have |
Made a bad typo, it was your lead, I typed |
22f8e11
to
f2409d0
Compare
@sheilamjones Excellent work, thanks, we might tweak a few more things going forward, but it does look good now, cheers |
Recompose the guide USING OPENID CONNECT (OIDC) TO PROTECT WEB APPLICATIONS USING AUTHORIZATION CODE FLOW (security-openid-connect-web-authentication.adoc) into the Diataxis framework.
The focus of this PR is to move and restructure the content into the topics. Further iterations are needed to further recomposition and style/editing changes
The following updates were made:
Closes: https://issues.redhat.com/browse/QDOCS-85
(and subtasks https://issues.redhat.com/browse/QDOCS-109 and https://issues.redhat.com/browse/QDOCS-110)