-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements for the Authentication mechanisms documentation #30658
Enhancements for the Authentication mechanisms documentation #30658
Conversation
@sberyozkin @jmartisk Hello Sergey and Jan! Here are some changes for the mentioned section. It is possible that we will need to move the revamped tables to a more specific sections, and I will provide a final review when this shifts will be done. Xrefs are currently not tested yet. Will do it as a final step Can I ask you for a review? Thank You. |
Adding a new file-name for the file renamed in: quarkusio/quarkus#30658
docs/src/main/asciidoc/security-authentication-mechanisms-concept.adoc
Outdated
Show resolved
Hide resolved
🙈 The PR is closed and the preview is expired. |
941e1d4
to
b40e040
Compare
docs/src/main/asciidoc/security-authentication-mechanisms-concept.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-authentication-mechanisms-concept.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-authentication-mechanisms-concept.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-authentication-mechanisms-concept.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-authentication-mechanisms-concept.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichalMaler Thanks for going ahead with creating a new table, IMHO it would be useful, a left a few comments.
By the way, please tweak the mutual TLS link at the very top of the builtin mechanisms section. I'm not sure though we need those Basic/Form/MTLS links given that right below them Basic/Form/MTLS subsections start ? Michelle, @michelle-purcell would you like to retain them ?
@sberyozkin I fixed the link. Will remove them if @michelle-purcell agrees they are redundant or just residuals after the content movement :) Let me know. |
docs/src/main/asciidoc/security-authentication-mechanisms-concept.adoc
Outdated
Show resolved
Hide resolved
6e8e37a
to
57c2249
Compare
docs/src/main/asciidoc/security-authentication-mechanisms-concept.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-authentication-mechanisms-concept.adoc
Outdated
Show resolved
Hide resolved
31400ad
to
40ada83
Compare
@sberyozkin I think we are ready to merge. |
docs/src/main/asciidoc/security-authentication-mechanisms-concept.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-authentication-mechanisms-concept.adoc
Outdated
Show resolved
Hide resolved
Hi @MichalMaler, good job on the restructuring here. I just had a couple of minor comments and suggestions. |
Thank you for quick and great review, as always :) Applied most of your suggestions. GJ! @sheilamjones |
d0f4196
to
b29f5df
Compare
docs/src/main/asciidoc/security-authentication-mechanisms-concept.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO it is now nearly ready to go.
@sheilamjones Please update your PR when you get a chance as Michal's PR points to the file which will only be resolvable once your PR gets merged :-), so for now please don't merge
a3d55dd
to
905ff8d
Compare
Hey @MichalMaler Sheila's PR is now on the main branch, can you please rebase and check the links, FYI, the OIDC web app concept doc has been renamed, so some minor sync will be needed for your PR, thanks |
Signed-off-by: Michal Maléř <mmaler@redhat.com> Apply suggestions from code review Co-authored-by: sberyozkin <sberyozkin@gmail.com> Fixes Signed-off-by: Michal Maléř <mmaler@redhat.com> Fixes Signed-off-by: Michal Maléř <mmaler@redhat.com> Fixes Signed-off-by: Michal Maléř <mmaler@redhat.com> Apply suggestions from code review Co-authored-by: jherrman <jherrman@redhat.com> Fixes from a peer review Signed-off-by: Michal Maléř <mmaler@redhat.com> Fixes Signed-off-by: Michal Maléř <mmaler@redhat.com> Fixes Signed-off-by: Michal Maléř <mmaler@redhat.com> Fixes Signed-off-by: Michal Maléř <mmaler@redhat.com> Fixes Signed-off-by: Michal Maléř <mmaler@redhat.com> Fixes Signed-off-by: Michal Maléř <mmaler@redhat.com> Fixes Signed-off-by: Michal Maléř <mmaler@redhat.com>
905ff8d
to
af69936
Compare
@sberyozkin Hello Sergey! Thx for letting me know. One additional xref fixed. The whole PR now using the new names that reflects Sheila's work. |
This should be merged too, but it is not my call: |
@MichalMaler Great work indeed, thanks very much |
I'm unmarking all the doc PRs for backports. They are all part of massive changes that shouldn't be backported. Please don't mark for backport massive structural changes to the doc. |
QDOCS-93: Authentication mechanisms revamping
Initial preview for tables movements:
https://github.com/quarkusio/quarkus/blob/a3d55ddf0f11b353d0835e76760de5fe9e2ef75a/docs/src/main/asciidoc/security-authentication-mechanisms-concept.adoc
Renaming/Redirecting PR for these changes:
quarkusio/quarkusio.github.io#1623
Signed-off-by: Michal Maléř mmaler@redhat.com