Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the absolute path is a directory when scanning for static files #3125

Merged
merged 1 commit into from
Jul 6, 2019

Conversation

Postremus
Copy link
Member

@Postremus Postremus commented Jul 6, 2019

instead of the relative path
This caused the welcome page not to be found in sub directories,
since the KnownPathResourceManager did not know about this specific
folder, and did not return a DirectoryResource
fixes #3091

and not if the relative one is an directory
This caused the welcome page not to be found in sub directories,
since the KnownPathResourceManager did not know about this specific
folder, and did not return a DirectoryResource
fixes quarkusio#3091
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@gsmet gsmet added this to the 0.19.0 milestone Jul 6, 2019
@gsmet gsmet merged commit 8ed8342 into quarkusio:master Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No redirect to index.html in subdirectory when running as uberjar
2 participants