Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated AppModel #32468

Merged
merged 1 commit into from Apr 13, 2023
Merged

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Apr 6, 2023

  • This removes the long-deprecated AppModel from the codebase

- This removes the long-deprecated AppModel from the codebase
@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Apr 6, 2023
@aloubyansky
Copy link
Member

I'm totally in favor of this change. It's right before the final release though. We need to make sure we don't break the platform with this change.

@gsmet
Copy link
Member

gsmet commented Apr 6, 2023

Let's not merge it now and make it a 3.1 item.

We won't have time to deal with the consequences.

@gastaldi
Copy link
Contributor Author

gastaldi commented Apr 6, 2023

@aloubyansky grepping the https://github.com/apache/camel-quarkus/ does not give any reference to this class (only ApplicationModel).

Can you confirm @ppalaga?

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it on ice until 3.1 development starts.

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 6, 2023

Failing Jobs - Building 8aff33d

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 19

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

io.quarkus.gradle.devmode.MultiSourceProjectDevModeTest.main line 22 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@gsmet gsmet added triage/on-ice Frozen until external concerns are resolved and removed triage/on-ice Frozen until external concerns are resolved labels Apr 11, 2023
@gsmet
Copy link
Member

gsmet commented Apr 13, 2023

Main is now 3.1 so we can merge.

@gsmet
Copy link
Member

gsmet commented Apr 13, 2023

@aloubyansky I let you approve and merge if you're happy with the change.

@aloubyansky aloubyansky merged commit 0505c1c into quarkusio:main Apr 13, 2023
44 of 46 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone Apr 13, 2023
@gastaldi gastaldi deleted the remove_app_model branch April 13, 2023 12:57
@ppalaga
Copy link
Contributor

ppalaga commented Apr 17, 2023

Sorry for the late response, yes, this is fine. Thanks for checking @gastaldi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants