Allow built in InstrumenterVertxTracer classes to be disabled
#35431
Conversation
If for example users do not want HTTP instrumentation, they can provide: `quarkus.otel.span.enabled-tracers=eventbus,sql` Resolves: quarkusio#35376
|
/cc @brunobat (opentelemetry), @radcortez (opentelemetry) |
There was a problem hiding this comment.
I'm not a fan at this stage because it's too soon.
It's too incomplete and It can mislead people to the amount instrumentations available.
After https://github.com/orgs/quarkusio/projects/13/views/23?pane=issue&itemId=34345199
We should consider an automated catalog and a way to switch on and off all of them
| } | ||
| // TODO - Selectively register this in the recorder if the SQL Client is available. | ||
| if (enabledTracers.contains(SpanConfig.Tracers.SQL)) { | ||
| vertxTracers.add(new SqlClientInstrumenterVertxTracer(openTelemetry)); |
There was a problem hiding this comment.
This clashes with quarkus.datasource.jdbc.telemetry=true
|
Right, I have no real insights, which is why I opened it as a draft |
|
Is there a precedence for having some sort of undocumented preview feature like this PR? This is something we really need and yes, it may be a bit of a blunt instrument at this stage, but not allowing at least some sort of way of turning off instruments is also a bit limiting? My ideal would be to allow the PR and then let it be used by people who are aware its undocumented at this stage but at least we can assess the impact on our apps. |
|
Maybe @brunobat has a better solution than this thus avoiding such a need for experimental features. |
|
Let's wait a couple of days for #35053 to complete... It's almost done and we can think about this then. |
|
@bcluap I've scheduled this for the next quarter. |
|
Thanks |
|
@bcluap, it is implemented here #38089. Available in main and 3.7.CR1 |
|
Aha great. Found it. So to turn them all off I can
put quarkus.otel.span.enabled-tracers=
Trying it now
…On Thu, Jan 18, 2024 at 4:41 PM Bruno Baptista ***@***.***> wrote:
@bcluap <https://github.com/bcluap>, it is implemented here #38089
<#38089>. Available in main and
3.7.CR1
—
Reply to this email directly, view it on GitHub
<#35431 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGMB23NAHBLYHACAUOG2N43YPEYCHAVCNFSM6AAAAAA3X6VEK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJYGYYDSNZXHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Added this entry to the wiki, it might help: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.7#opentelemetry |
If for example users do not want HTTP instrumentation, they can provide:
quarkus.otel.span.enabled-tracers=eventbus,sqlResolves: #35376