Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTelemetry: fine-grained instrumentation enablement #38089

Merged
merged 2 commits into from Jan 9, 2024
Merged

OpenTelemetry: fine-grained instrumentation enablement #38089

merged 2 commits into from Jan 9, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jan 8, 2024

@mkouba mkouba requested a review from brunobat January 8, 2024 15:36
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 8, 2024

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

@quarkus-bot

This comment has been minimized.

Sign in to view
brunobat
brunobat approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@brunobat brunobat left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You nailed it @mkouba!
The capabilities validation is now very tidy and all the different deactivation properties is simply defined.
Thanks!
Let's see what's the issue with the IT test before merging.

@mkouba
Copy link
Contributor Author

mkouba commented Jan 9, 2024

Let's see what's the issue with the IT test before merging.

I think that the test failed because it expects all the spans to be exported which does not always has to be the case; and that's probably the reason why the io.quarkus.opentelemetry.deployment.common.TestSpanExporter.getFinishedSpanItems(int) method exists. I will try to make the assertion a little bit more robust.

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 9, 2024 •
edited by github-actions bot

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit 02471b8 into quarkusio:main Jan 9, 2024
26 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Jan 9, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jan 9, 2024
@brunobat brunobat mentioned this pull request Jan 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobat brunobat brunobat approved these changes

Assignees
No one assigned
Labels
area/tracing kind/enhancement New feature or request
Projects
None yet
Milestone
3.7.0.CR1
Development

Successfully merging this pull request may close these issues.

OpenTelemetry - Disable Span/Scope creation
2 participants
@mkouba @brunobat