Introduce OidcRequestFilter

[sberyozkin]

Fixes #22432.

Related to #36563.

This PR adds an option to customize OIDC client requests made by either quarkus-oidc-client or quarkus-oidc extensions, where users can add new headers, bby analyzing the request Buffer body if necessary along the way.

Two tests have been added:

• Test that the request body can be analyzed (use case Improve OIDC client pluggability #22432)
• Test that a custom Authorization scheme can be added for GET (JWKS endpoint etc requests, use case OIDC ID token introspection #36563)

[sberyozkin]

@michalvavrik Hey Michal, should we also disable MySql test and keep the Postgresql one only ? It should be enough

[michalvavrik]

@michalvavrik Hey Michal, should we also disable MySql test and keep the Postgresql one only ? It should be enough

This is really pity, because there is nothing wrong with these tests, they are not even flaky. Insufficient CI makes them flaky:

2023-10-23T15:56:11.0914706Z 2023-10-23 15:56:11,049 INFO  [tc.qua.io/.0.4] (build-23) Container quay.io/keycloak/keycloak:22.0.4 started in PT28.958038924S
2023-10-23T15:56:15.1280828Z 2023-10-23 15:56:15,066 ERROR [io.qua.oid.dep.dev.key.KeycloakDevServicesProcessor] (build-23) Admin token can not be acquired: null [Error Occurred After Shutdown]
2023-10-23T15:56:15.2283056Z 2023-10-23 15:56:15,135 ERROR [io.qua.oid.dep.dev.key.KeycloakDevServicesProcessor] (build-23) Realm quarkus can not be created 401 - Unauthorized  [Error Occurred After Shutdown]

Yeah, I suppose we need to disable it, because IMO there is nothing to fix if CI doesn't have enough resources, or what else could be an issue?

[quarkus-bot]

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

[sberyozkin]

Thanks @michalvavrik @gastaldi, 2 reviews are sufficient, hey @pedroigor, any concerns, then please ping me

[sberyozkin]

@michalvavrik I can take care of disabling the mysql test following the same approach you did for mssql, we'd still have progresql in deployment and oracle in integration tests, decent coverage :-)

[github-actions]

🙈 The PR is closed and the preview is expired.

[calvernaz]

After changing my build.gradle.kts, gradle.properties and settings.gradle.kts to use the snapshot repository and version 999-SNAPSHOT, I get the build of materials, but the extensions still stuck on 3.5.0.

[michalvavrik]

After changing my build.gradle.kts, gradle.properties and settings.gradle.kts to use the snapshot repository and version 999-SNAPSHOT, I get the build of materials, but the extensions still stuck on 3.5.0.

Not sure I copy, that depends on BOM, right? Is you group id io.quarkus? (without platform)? You can provide an example.

[calvernaz]

yea the BOM seems to still carry quarkus-oidc and not the latest, which I expected.

quarkusPluginId=io.quarkus
quarkusPluginVersion=999-SNAPSHOT
quarkusPlatformGroupId=io.quarkus.platform
quarkusPlatformArtifactId=quarkus-bom
quarkusPlatformVersion=999-SNAPSHOT

and build.gradle.kts

    
    implementation(enforcedPlatform("${quarkusPlatformGroupId}:${quarkusPlatformArtifactId}:${quarkusPlatformVersion}"))
    implementation("io.quarkus:quarkus-resteasy-reactive-jackson")
    implementation("io.quarkus:quarkus-oidc")
    implementation("io.quarkus:quarkus-arc")

How can I use extensions snapshots then?

[michalvavrik]

IMO quarkusPlatformGroupId=io.quarkus.platform => quarkusPlatformGroupId=io.quarkus, I don't have super much experience with Gradle.

[calvernaz]

That did the job @michalvavrik, thanks!

[michalvavrik]

Perfect!