Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take @ConstrainedTo into account for interceptors #36664

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Take @ConstrainedTo into account for interceptors #36664

merged 1 commit into from
Oct 25, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Oct 24, 2023

Without this change interceptors meant to be
used on the client were being used on the
server as well

@geoand geoand requested a review from gastaldi October 24, 2023 12:32
gastaldi
gastaldi approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quarkus-bot

This comment has been minimized.

Sign in to view
@gsmet
Copy link
Member

gsmet commented Oct 24, 2023

OK, I'm on ^. Will rebase soon.

@geoand
Copy link
Contributor Author

geoand commented Oct 24, 2023

I just rebased :)

@geoand @gsmet
Take @ConstrainedTo into account for interceptors
8207192 
Without this change interceptors meant to be
used on the client were being used on the
server as well
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 24, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 24, 2023

Failing Jobs - Building 8207192

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 20

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/micrometer/deployment 
! Skipped: extensions/micrometer-registry-prometheus/deployment extensions/quartz/deployment extensions/scheduler/deployment and 22 more

📦 extensions/micrometer/deployment

✖ io.quarkus.micrometer.deployment.binder.StorkMetricsDisabledTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.redis.deployment.client.DevServicesRedisProcessor#startRedisContainers threw an exception: java.lang.RuntimeException: java.lang.IllegalStateException: Previous attempts to find a Docker environment failed. Will not retry. Please see logs and check configuration

@geoand geoand merged commit f606af6 into quarkusio:main Oct 25, 2023
43 of 44 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 25, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 25, 2023
@geoand geoand deleted the interceptors-constrained branch October 25, 2023 06:16
@gsmet gsmet modified the milestones: 3.6 - main, 3.5.1 Oct 26, 2023
@aloubyansky aloubyansky modified the milestones: 3.5.1, 3.2.8.Final Nov 2, 2023
mocenas added a commit to mocenas/quarkus-test-suite that referenced this pull request Nov 14, 2023
@mocenas
WIP: add test coverage for quarkusio/quarkus#36664
269d8f3
@mocenas mocenas mentioned this pull request Nov 14, 2023
Merged
9 tasks
@michalvavrik michalvavrik mentioned this pull request Nov 21, 2023
Merged
9 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.8.Final
Development

Successfully merging this pull request may close these issues.
4 participants
@geoand @gsmet @gastaldi @aloubyansky