Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keycloak Admin Client Reactive: Fix typo that allows users to customize ObjectMapper #36770

Merged

Conversation

michalvavrik
Copy link
Contributor

@michalvavrik michalvavrik commented Oct 29, 2023

I think config properties that @geoand tried to prevent are like quarkus.jackson.fail-on-unknown-properties, don't think they are prefixed with io.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 29, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@geoand geoand merged commit e979c79 into quarkusio:main Oct 30, 2023
19 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 30, 2023
@michalvavrik michalvavrik deleted the feature/fix-min-kc-admin-cl-typo branch October 30, 2023 07:41
@gsmet
Copy link
Member

gsmet commented Nov 6, 2023

Does it need to be backported to 3.5 or it's based on new stuff for 3.6?

@michalvavrik
Copy link
Contributor Author

Does it need to be backported to 3.5 or it's based on new stuff for 3.6?

It was added here #30529, so backporting makes sense.

@gsmet
Copy link
Member

gsmet commented Nov 6, 2023

Thanks, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants