Use custom ObjectMapper for Keycloak admin client if necessary #30529
Conversation
...n/java/io/quarkus/keycloak/admin/client/reactive/runtime/ResteasyReactiveClientProvider.java
Outdated
Show resolved
Hide resolved
|
Hi @geoand It may be worth registering a custom ObjectMapper to check that this test, https://github.com/quarkusio/quarkus/blob/main/integration-tests/keycloak-authorization/src/test/java/io/quarkus/it/keycloak/AdminClientTestCase.java , is still passing |
|
PR should be good to go now that the test was added (and another related bug fixed) |
...n-tests/keycloak-authorization/src/main/java/io/quarkus/it/keycloak/AdminClientResource.java
Show resolved
Hide resolved
|
Looks like we need to update more of the client tests to make CI happy |
This comment has been minimized.
This comment has been minimized.
Sorry Georgios, looks like it is a pretty sensitive change :-) |
|
It's a chance to do the right thing 🙂 |
|
It should be good now 🤞🏼 |
|
Getting there :-) |
|
Darn, more failures... I'll have a look tomorrow |
This comment has been minimized.
This comment has been minimized.
|
We can start with the duplicate one if it proves too sensitive to optimise |
|
This seems like the gift that keeps on giving... |
geoand
force-pushed
the
#30516
branch
2 times, most recently
from
784de2f
to
e3c8a4a
Compare
This comment has been minimized.
This comment has been minimized.
|
I believe it should be fine now. This turned out to be a lot more than I bargained for :) |
|
I removed the backport label because this has the potential to cause issues: Essentially we used to mix the client's and server's Jackson related MessageBodyReader / Writer classes, which now we don't (this is the proper behavior). |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
* Adding rest-client-reactive-jackson extensions to modules using reactive rest client. This change is needed as the server and client extension has been split in quarkusio/quarkus#30529
|
@geoand Imho this should be in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.0#resteasy-reactive - as the decoupling can break the user apps (as it did for our tests) |
|
I don't see why we would, because |
Fixes: #30516