Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quarkus dev broken for command mode arguments #37961

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

MaciejDromin
Copy link
Contributor

@MaciejDromin MaciejDromin commented Dec 29, 2023

It fixes #37921
In particular second point where bottom text does not update after args change

@MaciejDromin MaciejDromin marked this pull request as ready for review December 30, 2023 20:51
@gsmet
Copy link
Member

gsmet commented Jan 3, 2024

@maxandersen could you test that one?

Copy link
Contributor

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works! LGTM.

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 17, 2024

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit d481e50 into quarkusio:main Jan 23, 2024
50 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Jan 23, 2024
@gsmet
Copy link
Member

gsmet commented Jan 23, 2024

Merged, thanks!

@gsmet gsmet modified the milestones: 3.9 - main, 3.7.0 Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarkus dev broken for command mode arguments
3 participants