Docs: Final edits, Style enhancements, Vale checks #38048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/docstyle
sheilamjones
force-pushed
the
QDOCS-537-finalchecks-JAN
branch
from
1f69966
to
b9fb249
Compare
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 5, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
|
Thanks @sheilamjones for this quality update, a lot of changes, I've proposed a few updates but overall looks great |
|
🙈 The PR is closed and the preview is expired. |
sheilamjones
force-pushed
the
QDOCS-537-finalchecks-JAN
branch
from
b9fb249
to
1813d24
Compare
|
Many thanks @sberyozkin for your review. I have implemented your proposals and reverted some changes per your suggestions. I did have just a couple of outstanding questions. |
|
Update: setting back to Draft until all updates are done and approvals are received. |
MichalMaler
reviewed
Jan 8, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
|
@sheilamjones Added my review. Cheers! |
sheilamjones
force-pushed
the
QDOCS-537-finalchecks-JAN
branch
from
48f3f36
to
e1acb9e
Compare
MichalMaler
approved these changes
Jan 15, 2024
|
@sheilamjones Thanks for applying my suggestions. LGTM, approving. :) |
sberyozkin
reviewed
Jan 15, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 15, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 15, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 15, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 15, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 15, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 15, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 15, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 15, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 15, 2024
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
|
Hey @sheilamjones, a few more suggestions here, a nice cleanup over all, thanks |
sheilamjones
force-pushed
the
QDOCS-537-finalchecks-JAN
branch
from
e1acb9e
to
576c7fe
Compare
sheilamjones
force-pushed
the
QDOCS-537-finalchecks-JAN
branch
from
576c7fe
to
0da97c3
Compare
|
Many thanks again @sberyozkin. I implemented your additional suggestions and just have a couple of small outstanding comments for your signoff, then this PR should be ready to merge. |
sheilamjones
force-pushed
the
QDOCS-537-finalchecks-JAN
branch
from
0da97c3
to
6a06b41
Compare
sheilamjones
force-pushed
the
QDOCS-537-finalchecks-JAN
branch
from
6a06b41
to
0e37bd9
Compare
sberyozkin
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Great work @sheilamjones, thanks for your patience.
Merging now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes style issues (title capitalization, one sentence per line...), links, Vale issues, and some grammar as per the preferred Quarkus Contributor guidelines in the security-oidc-code-flow-authentication.adoc (OIDC code flow authentication guide)
Reference: QDOCS-537