Fix Build Scan conditional publication #38102
Conversation
…abled publication to be captured for republication
jprinet
force-pushed
the
fix/conditional-build-scan-publication
branch
from
2b8efda
to
5d61c69
Compare
| try { | ||
| def storageLocationTmpDir = java.nio.file.Files.createTempDirectory(java.nio.file.Paths.get(System.env.RUNNER_TEMP), "buildScanTmp").toAbsolutePath() | ||
| log.debug('Update storage location to ' + storageLocationTmpDir) | ||
| gradleEnterprise.setStorageDirectory(storageLocationTmpDir) |
There was a problem hiding this comment.
Is this instance global to the build (or even to the module at hand)? Because if so, we would need to set it to the default value in the publish == true case.
There was a problem hiding this comment.
The storage directory is set to .m2/.gradle-enterprise when the extension is configured on each build startup
There was a problem hiding this comment.
And this script is executed independently and gradleEnterprise isn't global to the whole build and doesn't leak?
I was worried about gradleEnterprise being global for the whole build and this case could then happen:
- module1 (storageDirectory == default)
- module2 (storageDirectory == default)
- test build in module 2 (storageDirectory == tmp dir)
- module3 (storageDirectory == tmp dir while we would like it to be the default)
There was a problem hiding this comment.
I logged the storage directory and can confirm that it is reset on each and every build to the default value (even after a previous build setting it to a temporary directory)
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. You can consult the Develocity build scans. |
Issue
The Develocity Build Scan publication is disabled for test builds (see here).
Disabling the publication does not prevent the scan dump from being created and later on captured while running the Quarkus CI Github workflow.
Captured scan dumps are eventually published to Develocity in a separate workflow, which was not the intention.
Fix
There is no way to prevent the scan dump from being created, the best option is to make sure the scan dump won't be captured by changing its storage location on CI.