Make sure extension metadata properties are not including timestamps #38365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/config
area/core
area/devtools
gsmet
reviewed
Jan 24, 2024
|
|
||
| /** | ||
| * Stores properties into a file sorting the keys alphabetically and following | ||
| * {@link Properties#store(Writer, String)} format but skipping the timestamp and comments. |
There was a problem hiding this comment.
How exactly do you skip the timestamps?
There was a problem hiding this comment.
By writing each line in the methods below instead of calling Properties.store(...)
There was a problem hiding this comment.
Ah OK. It's Properties.store() adding the timestamps!
There was a problem hiding this comment.
You can bypass that by running with -Djava.properties.date=, but I think the current solution is easier to understand
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. You can consult the Develocity build scans. |
gsmet
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38364