Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Hibernate ORM 6.4.3.Final #38558

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Feb 2, 2024

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/panache labels Feb 2, 2024
@yrodiere yrodiere added triage/backport-3.8 dependencies Pull requests that update a dependency file and removed area/panache area/dependencies Pull requests that update a dependency file labels Feb 2, 2024
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/panache labels Feb 2, 2024
@quarkus-bot

This comment has been minimized.

@yrodiere
Copy link
Member Author

yrodiere commented Feb 2, 2024

Alright, Kotlin... Back to the drawing board, I guess.

@yrodiere
Copy link
Member Author

yrodiere commented Feb 2, 2024

So it seems kotlin-maven-plugin doesn't handle dependency management for annotationProcessorPaths... Which is weird since it's supposedly been supported since version 1.9.0, and we use 1.9.22: https://youtrack.jetbrains.com/issue/KT-59521. I'll dig in.

@yrodiere
Copy link
Member Author

yrodiere commented Feb 2, 2024

Okay my bad, the commit says "plugin management is also supported". Dependency management is not.
I'll keep specifying the Hibernate ORM version explicitly for Kotlin modules.

Removes workaround for HHH-17683 in Panache.

We need to keep specifying the version for Kotlin extensions due to
kotlin-maven-plugin not taking dependency management into account;
see
quarkusio#37477 (comment).
However, we now use the same version as the one we expect people to use
in applications (6.4.3), so it's no longer so much of a hack.

This reverts commit f4b489b.
This reverts commit e745fe3.
@yrodiere
Copy link
Member Author

yrodiere commented Feb 2, 2024

I fixed the kotlin-maven-plugin issue, let's see what CI thinks of this.

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 2, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 2, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c62dc92.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.


Flaky tests

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream

  • Assertion condition defined as a io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

@yrodiere
Copy link
Member Author

yrodiere commented Feb 2, 2024

Flaky tests

Wait what? I don't know who worked on that, but it's a great feature :)

@yrodiere yrodiere merged commit fe816f8 into quarkusio:main Feb 2, 2024
49 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Feb 2, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 2, 2024
@gsmet gsmet modified the milestones: 3.9 - main, 3.7.2 Feb 6, 2024
@yrodiere yrodiere deleted the orm6.4.3 branch February 12, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/panache dependencies Pull requests that update a dependency file triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove workaround for HHH-17683 in Panache
3 participants