Fix StorkClientRequestFilter exception handling #39731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damianorenfer
force-pushed
the
fix/resteasy-StorkClientRequestFilter-exception-handling
branch
2 times, most recently
from
b4818e8
to
d40f0e8
Compare
damianorenfer
force-pushed
the
fix/resteasy-StorkClientRequestFilter-exception-handling
branch
2 times, most recently
from
13f87a7
to
0058eff
Compare
aureamunoz
approved these changes
Mar 27, 2024
damianorenfer
force-pushed
the
fix/resteasy-StorkClientRequestFilter-exception-handling
branch
2 times, most recently
from
b3fcc26
to
7f59def
Compare
This comment has been minimized.
This comment has been minimized.
|
cc @damianorenfer Could you please run the build or format command to have a proper code and then push it again? |
damianorenfer
force-pushed
the
fix/resteasy-StorkClientRequestFilter-exception-handling
branch
from
7f59def
to
bf01d15
Compare
|
Done, thanks! |
damianorenfer
force-pushed
the
fix/resteasy-StorkClientRequestFilter-exception-handling
branch
4 times, most recently
from
9a554b3
to
59189e7
Compare
aureamunoz
approved these changes
Apr 3, 2024
aureamunoz
approved these changes
Apr 3, 2024
This comment has been minimized.
This comment has been minimized.
damianorenfer
force-pushed
the
fix/resteasy-StorkClientRequestFilter-exception-handling
branch
from
59189e7
to
61699ac
Compare
aureamunoz
approved these changes
Apr 3, 2024
aureamunoz
approved these changes
Apr 3, 2024
cescoffier
approved these changes
Apr 3, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Exceptions were not caught properly because a Uni subscription was done outside a try-catch block.
damianorenfer
force-pushed
the
fix/resteasy-StorkClientRequestFilter-exception-handling
branch
from
61699ac
to
04cffc5
Compare
geoand
added
the
triage/waiting-for-ci
Status for workflow
|
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
Thanks for this work, we will get it backported to the next 3.9. |
|
Awesome thanks, can you also backport it to 3.8 (LTS)? Or should I do it? |
|
I marked it for backport to 3.8 too but we need some bake time in 3.9 first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions were not caught properly because a Uni subscription was done outside a try-catch block.