Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow quarkus.application.name to be overridden for Spring Cloud Config Server #41035

Conversation

thibaultmeyer
Copy link
Contributor

@thibaultmeyer thibaultmeyer commented Jun 6, 2024

@quarkus-bot quarkus-bot bot added the area/spring Issues relating to the Spring integration label Jun 6, 2024
@thibaultmeyer thibaultmeyer force-pushed the feature/allow-quarkus-application-name-overriden-spring-cloud-config branch from cf07431 to 9bd16be Compare June 6, 2024 17:10
@thibaultmeyer
Copy link
Contributor Author

@geoand

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Any chance we can get a test?

@thibaultmeyer
Copy link
Contributor Author

yes, I'll try to add some unit tests

@geoand
Copy link
Contributor

geoand commented Jun 6, 2024

I was thinking of something similar to SpringCloudConfigClientGatewayTest

@thibaultmeyer thibaultmeyer force-pushed the feature/allow-quarkus-application-name-overriden-spring-cloud-config branch 3 times, most recently from d63167d to a24924c Compare June 6, 2024 18:47
@thibaultmeyer
Copy link
Contributor Author

I've added new unit tests, but I'm not 100% sure it's OK.

@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Jun 7, 2024

Please see output above for the command that needs to be run in order to properly format the code

@thibaultmeyer thibaultmeyer force-pushed the feature/allow-quarkus-application-name-overriden-spring-cloud-config branch from a24924c to 0846666 Compare June 7, 2024 17:59
@thibaultmeyer
Copy link
Contributor Author

Please see output above for the command that needs to be run in order to properly format the code

done

@quarkus-bot

This comment has been minimized.

@thibaultmeyer thibaultmeyer force-pushed the feature/allow-quarkus-application-name-overriden-spring-cloud-config branch 2 times, most recently from e3c6218 to ff26a55 Compare June 8, 2024 20:31
@thibaultmeyer
Copy link
Contributor Author

thibaultmeyer commented Jun 8, 2024

Import are now sorted.

mvn -f . net.revelc.code:impsort-maven-plugin:1.10.0:sort

@quarkus-bot

This comment has been minimized.

@thibaultmeyer
Copy link
Contributor Author

thibaultmeyer commented Jun 9, 2024

I repushed an import modification following the structure of this file: LambdaHttpHandlerTest.java.

EDIT : I definitevely dont understand how work import structure rules in Quarkus. And mvn command fail on my computer :

Error:  The build could not read 1 project -> [Help 1]
Error:    
Error:    The project io.quarkus:quarkus-spring-cloud-config-client:999-SNAPSHOT (/home/runner/work/quarkus/quarkus/extensions/spring-cloud-config-client/runtime/pom.xml) has 12 errors
Error:      Non-resolvable import POM: The following artifacts could not be resolved: io.quarkus:quarkus-bom:pom:999-SNAPSHOT (absent): Could not find artifact io.quarkus:quarkus-bom:pom:999-SNAPSHOT @ io.quarkus:quarkus-build-parent:999-SNAPSHOT, 

@geoand can you please help me?

EDIT 2 : seems OK, to many new line between import and class definition ;)

@thibaultmeyer thibaultmeyer force-pushed the feature/allow-quarkus-application-name-overriden-spring-cloud-config branch 2 times, most recently from d3cae63 to 4d2ce73 Compare June 9, 2024 08:03
@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Jun 9, 2024
@thibaultmeyer thibaultmeyer force-pushed the feature/allow-quarkus-application-name-overriden-spring-cloud-config branch from c959d0b to 96ed4e4 Compare June 9, 2024 08:28
…ig Server

Signed-off-by: Thibault Meyer <meyer.thibault@gmail.com>
@thibaultmeyer thibaultmeyer force-pushed the feature/allow-quarkus-application-name-overriden-spring-cloud-config branch from 96ed4e4 to 92aadc7 Compare June 9, 2024 08:33
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 9, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 92aadc7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@geoand geoand merged commit 6d43733 into quarkusio:main Jun 9, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone Jun 9, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jun 9, 2024
@thibaultmeyer thibaultmeyer deleted the feature/allow-quarkus-application-name-overriden-spring-cloud-config branch June 9, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/spring Issues relating to the Spring integration kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow quarkus.application.name to be overridden for Spring Cloud Config Server
3 participants