-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow quarkus.application.name to be overridden for Spring Cloud Config Server #41035
Allow quarkus.application.name to be overridden for Spring Cloud Config Server #41035
Conversation
thibaultmeyer
commented
Jun 6, 2024
•
edited by geoand
Loading
edited by geoand
- Resolves: Allow quarkus.application.name to be overridden for Spring Cloud Config Server #41011
cf07431
to
9bd16be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Any chance we can get a test?
yes, I'll try to add some unit tests |
I was thinking of something similar to |
d63167d
to
a24924c
Compare
I've added new unit tests, but I'm not 100% sure it's OK. |
This comment has been minimized.
This comment has been minimized.
Please see output above for the command that needs to be run in order to properly format the code |
a24924c
to
0846666
Compare
done |
This comment has been minimized.
This comment has been minimized.
e3c6218
to
ff26a55
Compare
Import are now sorted.
|
This comment has been minimized.
This comment has been minimized.
I repushed an import modification following the structure of this file: LambdaHttpHandlerTest.java. EDIT : I definitevely dont understand how work import structure rules in Quarkus. And
@geoand can you please help me? EDIT 2 : seems OK, to many new line between import and class definition ;) |
d3cae63
to
4d2ce73
Compare
c959d0b
to
96ed4e4
Compare
…ig Server Signed-off-by: Thibault Meyer <meyer.thibault@gmail.com>
96ed4e4
to
92aadc7
Compare
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!