Doc for parameter quarkus.native.add-all-charsets #41877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the suggestion. I think it makes perfect sense to add some clarifications. I think it needs a bit of word tweaking though, I’ll have a look soon. |
|
@gsmet ok thanks for the feedback. Of course choose the sentence which you think are more fit :) |
|
@fugerit79 can you have a look at the commit I just pushed? I think it should work for you but please be vocal if it wouldn't have helped you. Thanks! |
It looks perfect to me. It seems a good idea to mention the jdbc-oracle extension. |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed documentation for quarkus.native.add-all-charsets parameter from :
If all character sets should be added to the native image. This increases image sizeTo something like :
If all character sets should be added to the native image (Different from GraalVM option : -H:+AddAllCharsets; this flag enables quarkus extensions to do some specific work). This increases image sizeIn brief : we spent a lot of time finding out this options was fixing our issue with oracle connection from native image.
More informations on issue : #41876