Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Vert.x/RESTeasy hang if HTTP URL handler is not installed #4304

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@stuartwdouglas
Copy link
Member

stuartwdouglas commented Oct 2, 2019

Also add Vert.x error handler

@stuartwdouglas stuartwdouglas force-pushed the stuartwdouglas:vertx-hang branch 2 times, most recently from 9637ba6 to e76a353 Oct 2, 2019
@geoand geoand requested a review from cescoffier Oct 2, 2019
Copy link
Member

cescoffier left a comment

I made a small comment, but the rest looks good.

Also add Vert.x error handler
@stuartwdouglas stuartwdouglas force-pushed the stuartwdouglas:vertx-hang branch from e76a353 to 83c4327 Oct 2, 2019
@geoand

This comment has been minimized.

Copy link
Contributor

geoand commented Oct 2, 2019

The CI failure seems to be a jcenter issue. I propose we ignore it, it's been happening on various PRs

@geoand geoand added this to the 0.24.0 milestone Oct 2, 2019
@cescoffier cescoffier merged commit b874287 into quarkusio:master Oct 2, 2019
20 of 22 checks passed
20 of 22 checks passed
quarkusio.quarkus Build #20191002.22 failed
Details
quarkusio.quarkus (Run JVM Tests Run_TCKs) Run JVM Tests Run_TCKs failed
Details
quarkusio.quarkus (Build for Native Build JDK8 Linux) Build for Native Build JDK8 Linux succeeded
Details
quarkusio.quarkus (Maven Cache Linux Maven Repo) Maven Cache Linux Maven Repo succeeded
Details
quarkusio.quarkus (Maven Cache Windows Maven Repo) Maven Cache Windows Maven Repo succeeded
Details
quarkusio.quarkus (Native Tests amazon-dynamodb, amazon-lambda) Native Tests amazon-dynamodb, amazon-lambda succeeded
Details
quarkusio.quarkus (Native Tests artemis-core, artemis-jms, kafka) Native Tests artemis-core, artemis-jms, kafka succeeded
Details
quarkusio.quarkus (Native Tests elytron-security-oauth2, elytron-security, keycloak) Native Tests elytron-security-oauth2, elytron-security, keycloak succeeded
Details
quarkusio.quarkus (Native Tests flyway, hibernate-orm-panache, reactive-pg-client) Native Tests flyway, hibernate-orm-panache, reactive-pg-client succeeded
Details
quarkusio.quarkus (Native Tests hibernate-search-elasticsearch) Native Tests hibernate-search-elasticsearch succeeded
Details
quarkusio.quarkus (Native Tests infinispan-cache-jpa, infinispan-client, mongodb-client, mongodb-panache, neo4j, narayana-stm) Native Tests infinispan-cache-jpa, infinispan-client, mongodb-client, mongodb-panache, neo4j, narayana-stm succeeded
Details
quarkusio.quarkus (Native Tests jackson, jgit, kogito, kubernetes-client) Native Tests jackson, jgit, kogito, kubernetes-client succeeded
Details
quarkusio.quarkus (Native Tests jpa, jpa-postgresql, jpa-mysql) Native Tests jpa, jpa-postgresql, jpa-mysql succeeded
Details
quarkusio.quarkus (Native Tests jpa-h2, jpa-mariadb, jpa-mssql) Native Tests jpa-h2, jpa-mariadb, jpa-mssql succeeded
Details
quarkusio.quarkus (Native Tests main) Native Tests main succeeded
Details
quarkusio.quarkus (Native Tests resteasy-jackson, vertx, vertx-http, virtual-http) Native Tests resteasy-jackson, vertx, vertx-http, virtual-http succeeded
Details
quarkusio.quarkus (Native Tests spring-di, spring-web, spring-data-jpa) Native Tests spring-di, spring-web, spring-data-jpa succeeded
Details
quarkusio.quarkus (Native Tests tika, hibernate-validator, test-extension) Native Tests tika, hibernate-validator, test-extension succeeded
Details
quarkusio.quarkus (Run JVM Tests Build JDK8 Linux) Run JVM Tests Build JDK8 Linux succeeded
Details
quarkusio.quarkus (Run JVM Tests Linux JDK11 Build) Run JVM Tests Linux JDK11 Build succeeded
Details
quarkusio.quarkus (Run JVM Tests Linux JDK12 Build) Run JVM Tests Linux JDK12 Build succeeded
Details
quarkusio.quarkus (Run JVM Tests Windows JVM Build) Run JVM Tests Windows JVM Build succeeded
Details
@cescoffier cescoffier added bug and removed waiting-for-ci labels Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.