Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Vert.x/RESTeasy hang if HTTP URL handler is not installed #4304

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Prevent Vert.x/RESTeasy hang if HTTP URL handler is not installed #4304

merged 1 commit into from
Oct 2, 2019

Conversation

stuartwdouglas
Copy link
Member

Also add Vert.x error handler

@stuartwdouglas stuartwdouglas force-pushed the vertx-hang branch 2 times, most recently from 9637ba6 to e76a353 Compare October 2, 2019 03:15
@geoand geoand requested a review from cescoffier October 2, 2019 06:14
cescoffier
cescoffier approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a small comment, but the rest looks good.

...nsions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxHttpRecorder.java Outdated Show resolved Hide resolved
@stuartwdouglas stuartwdouglas added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 2, 2019
@geoand
Copy link
Contributor

geoand commented Oct 2, 2019

The CI failure seems to be a jcenter issue. I propose we ignore it, it's been happening on various PRs

@geoand geoand added this to the 0.24.0 milestone Oct 2, 2019
@cescoffier cescoffier merged commit b874287 into quarkusio:master Oct 2, 2019
@cescoffier cescoffier added kind/bug Something isn't working and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartwdouglas @geoand @cescoffier