Fix broken native build of generated projects #5005

geoand · 2019-10-29T18:26:23Z

I honestly don't know why stacktraces need to be enabled for the generated native image to work properly.

Without this fix, the native image build of the generated (via the maven tooling) projects would fail:

First with a NPE
But even going past the NPE, the generated native image when run gave output like this:

Exception in thread "Thread-1" java.lang.Error: java.lang.NullPointerException
Caused by: java.lang.NullPointerException
java.lang.NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom
java.lang.NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom
2019-10-29 20:17:38,761 ERROR [io.ver.cor.imp.ContextImpl] (vert.x-eventloop-thread-0) Unhandled exception: java.lang.NullPointerException: channel

Exception in thread "main" java.lang.RuntimeException: Failed to start quarkus
Caused by: java.lang.NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom

geoand · 2019-10-29T18:34:27Z

@gsmet can you try it out? Asking because I know you could reproduce the issue

gsmet · 2019-10-29T18:48:06Z

I sure will.

gsmet · 2019-10-29T18:49:21Z

One thing we need is to move one of the current IT to the new way of doing things. It’s not acceptable to discover this by pure luck.

dmlloyd · 2019-10-29T18:54:12Z

My hypothesis is that this fails because the class is reinitialized, but the static init does some things that are disallowed during native image run time.

I think this class cannot be reinitialized at run time. Instead I think we'll have to reinitialize specific fields manually.

geoand · 2019-10-29T19:06:24Z

One thing we need is to move one of the current IT to the new way of doing things. It’s not acceptable to discover this by pure luck.

I can do that in a follow up

gsmet

So I confirm it fixes the issue for me too and with a newly created simple project, I'm now able to create a native image.

I think we need Stuart to confirm if that's the right fix though.

For Stuart:

create a project with mvn io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:create -DprojectGroupId=org.acme -DprojectArtifactId=getting-started -DclassName="org.acme.quickstart.GreetingResource" -Dpath="/hello" -Dextensions="openapi"
cd getting-started
mvn clean install -Dnative will fail with a NPE in BuildMojo at line 190
with the if Georgios added, we pass this step but then we have another NPE that the change of default value for the full stacktrace somehow fixes.

gsmet · 2019-10-29T20:04:43Z

core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java

@@ -165,7 +165,7 @@
    /**
     * If full stack traces are enabled in the resulting image
     */
-    @ConfigItem(defaultValue = "false")
+    @ConfigItem(defaultValue = "true")


Yes, this is definitely dark magic.

This change was unintentional. I must have made a mistake when creating this, or maybe it got missed in one of the many rebases.

gsmet · 2019-10-29T20:05:35Z

devtools/maven/src/main/java/io/quarkus/maven/BuildMojo.java

-            }
-            if (result.getJar().isUberJar()) {
-                projectHelper.attachArtifact(project, result.getJar().getPath().toFile(), "runner");
+            if (result.getJar() != null) {


I'm not sure if the issue is the null test or the fact that result.getJar() is empty. When using XML config, it's not as we don't have the NPE so I think we need Stuart to say if it's normal or not.

This is ok, the NativeImageMojo does not attempt to look at the jar result.

gsmet · 2019-10-29T20:06:58Z

core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java

@@ -165,7 +165,7 @@
    /**
     * If full stack traces are enabled in the resulting image
     */
-    @ConfigItem(defaultValue = "false")
+    @ConfigItem(defaultValue = "true")
    public boolean fullStackTraces;


What bugs me a bit too is that now, the output when creating the native image is very scarce. I don't know if it's normal or not but we used to have a couple of Quarkus lines and now we have:

21:02:57,864 INFO [org.jbo.threads] JBoss Threads version 3.0.0.Final

and that's it.

I will look into this

Fix broken native build of generated projects

265d701

gsmet reviewed Oct 29, 2019

View reviewed changes

gsmet added the triage/requires-stuart label Oct 29, 2019

stuartwdouglas approved these changes Oct 29, 2019

View reviewed changes

geoand merged commit cf8ea35 into quarkusio:master Oct 29, 2019

geoand added this to the 0.27.0 milestone Oct 29, 2019

geoand deleted the generated-native-fix branch October 30, 2019 09:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix broken native build of generated projects #5005

Fix broken native build of generated projects #5005

geoand commented Oct 29, 2019 •

edited

Loading

geoand commented Oct 29, 2019

gsmet commented Oct 29, 2019

gsmet commented Oct 29, 2019

dmlloyd commented Oct 29, 2019

geoand commented Oct 29, 2019

gsmet left a comment

gsmet Oct 29, 2019

stuartwdouglas Oct 29, 2019

gsmet Oct 29, 2019

stuartwdouglas Oct 29, 2019

gsmet Oct 29, 2019

stuartwdouglas Oct 29, 2019

Fix broken native build of generated projects #5005

Fix broken native build of generated projects #5005

Conversation

geoand commented Oct 29, 2019 • edited Loading

geoand commented Oct 29, 2019

gsmet commented Oct 29, 2019

gsmet commented Oct 29, 2019

dmlloyd commented Oct 29, 2019

geoand commented Oct 29, 2019

gsmet left a comment

Choose a reason for hiding this comment

gsmet Oct 29, 2019

Choose a reason for hiding this comment

stuartwdouglas Oct 29, 2019

Choose a reason for hiding this comment

gsmet Oct 29, 2019

Choose a reason for hiding this comment

stuartwdouglas Oct 29, 2019

Choose a reason for hiding this comment

gsmet Oct 29, 2019

Choose a reason for hiding this comment

stuartwdouglas Oct 29, 2019

Choose a reason for hiding this comment

geoand commented Oct 29, 2019 •

edited

Loading