Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @Cache and @NoCache tests #5563

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Add @Cache and @NoCache tests #5563

merged 1 commit into from
Nov 28, 2019

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Nov 18, 2019 •
edited by gsmet
Loading

This PR provides tests for #5551 that would ensure that @NoCache and @Cache work as advertised.

gsmet: But apparently, the OP still has the issue.

@gastaldi gastaldi added this to the 1.1.0 milestone Nov 18, 2019
gsmet
gsmet requested changes Nov 18, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for the OP's feedback before merging this PR and (thus) closing the issue.

@geoand
Copy link
Contributor

geoand commented Nov 18, 2019

Seems like a resonable change, but @gsmet's suggestion also makes perfect sense

@geoand
Copy link
Contributor

geoand commented Nov 22, 2019

I see from #5551 that this doesn't solve your issue @rboei ?

gsmet
gsmet approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't hurt to have a test. Let's merge this even if it doesn't seem to solve the OP's original issue.

@gsmet gsmet merged commit 294fda9 into quarkusio:master Nov 28, 2019
@gastaldi gastaldi deleted the nocache branch December 12, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@geoand geoand Awaiting requested review from geoand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@gastaldi @geoand @gsmet