Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document property indirection for passwords coming from Vault - Fixes #3279 #5726

Merged
merged 1 commit into from
Nov 24, 2019
Merged

Conversation

vsevel
Copy link
Contributor

@vsevel vsevel commented Nov 24, 2019

This provides documentation (and a test) on the ability to store a password in vault, and refer to it anywhere in the configuration using property indirection.

This was made possible thanks to #3937.

This solves for instance #3279, assuming Vault is an option in the user's environment.

cc @sberyozkin

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsevel IMHO it is top class, the extensions can continue using their own properties to work with Vault :-)

@sberyozkin sberyozkin merged commit 7c34e9d into quarkusio:master Nov 24, 2019
@machi1990 machi1990 added this to the 1.1.0 milestone Nov 24, 2019
@vsevel
Copy link
Contributor Author

vsevel commented Nov 24, 2019

@sberyozkin thanks for merging; you were too fast for me ;) I just finished running a full example on mail+vault quickstart using the property indirection.

here is the config I used:

quarkus.vault.secret-config-kv-path=myapps/vault-quickstart/config
        
quarkus.mailer.from=test@quarkus.io
quarkus.mailer.host=localhost
quarkus.mailer.port=1025
quarkus.mailer.ssl=false
quarkus.mailer.username=foo
quarkus.mailer.password=${a-private-key}

and for the smtp server:

docker run -p 1080:1080 -p 1025:1025 djfarrelly/maildev --incoming-user foo --incoming-pass 123456 -v

the extensions can continue using their own properties to work with Vault :-)

indeed. it is pretty nice.
(except for the lack of property value refresh)

@vsevel vsevel deleted the issue_3279 branch November 24, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants