Fixes the extension author guide WRT the new quarkus-extension.yaml #5805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Nov 27, 2019
| @@ -378,7 +378,7 @@ The above sequence of commands does the following: | |||
| A Maven build performed immediately after generating the modules should fail due to a `fail()` assertion in one of the test classes. | |||
|
|
|||
| There is one step (specific to the Quarkus source tree) that you should do manually when creating a new extension: | |||
| Add the extension coordinates to `devtools/common/src/main/filtered/extensions.json`. | |||
| Create a `quarkus-extension.yaml` file that describe your extension inside the runtime module `src/main/resources/META-INF` folder. | |||
There was a problem hiding this comment.
So the error was here before but Create should be create after a colon. Can you fix that while you're at it?
I also think an example of an existing extension that has all the right information would be helpful.
There was a problem hiding this comment.
done, I add an example from Agroal
loicmathieu
force-pushed
the
fix/extension-author-guide
branch
from
de527cf
to
0d70aa2
Compare
gsmet
approved these changes
Nov 27, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.