Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC - support synthetic observer methods added at build time #6888

Merged
merged 4 commits into from
Feb 3, 2020
Merged

ArC - support synthetic observer methods added at build time #6888

merged 4 commits into from
Feb 3, 2020

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jan 30, 2020

@mkouba mkouba added this to the 1.3.0 milestone Jan 30, 2020
@mkouba mkouba requested a review from manovotn January 30, 2020 13:04
@boring-cyborg boring-cyborg bot added the area/arc Issue related to ARC (dependency injection) label Jan 30, 2020
@mkouba mkouba mentioned this pull request Jan 30, 2020
Merged
manovotn
manovotn reviewed Jan 30, 2020
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, added few comments.

...pendent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/ObserverGenerator.java Show resolved Hide resolved
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanRegistrar.java Outdated Show resolved Hide resolved
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/ObserverInfo.java Show resolved Hide resolved
...ent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/QualifierConfigurator.java Show resolved Hide resolved
@mkouba mkouba requested a review from manovotn January 31, 2020 10:30
@mkouba
Copy link
Contributor Author

mkouba commented Jan 31, 2020

The windows job fails with unrelated error: Caused by: java.net.BindException: Address already in use: bind.

@mkouba mkouba merged commit b9c9749 into quarkusio:master Feb 3, 2020
@manovotn manovotn mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi left review comments

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Milestone
1.3.0.Alpha1
Development

Successfully merging this pull request may close these issues.

ArC - support synthetic observer methods added at build time
3 participants
@mkouba @gastaldi @manovotn