Removed unused properties according to issue 4630 #7022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/security
area/smallrye
area/spring
sberyozkin
approved these changes
Feb 6, 2020
gastaldi
added
the
triage/waiting-for-ci
|
@gastaldi Well, the Windows fail is definitely unrelated. |
|
@gastaldi Is there anything this PR is waiting for? |
|
Passing CI would be my guess. Can you rebase with the latest master please? |
Karm
force-pushed
the
unused-jwt-properties
branch
from
83dc267
to
be2a218
Compare
Removes unused properties ```quarkus.smallrye-jwt.auth-mechanism``` and ```quarkus.security.users.embedded.auth-mechanism```. Tests continue to pass for extensions/elytron-security-properties-file/deployment, extensions/smallrye-jwt/deployment, extensions/spring-security/deployment, integration-tests/spring-web.
Karm
force-pushed
the
unused-jwt-properties
branch
from
be2a218
to
e13dfeb
Compare
|
@gastaldi Apparently, the CI randomly found a stable state, so this is ready for merge... |
|
Merged. Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unused properties
quarkus.smallrye-jwt.auth-mechanismandquarkus.security.users.embedded.auth-mechanism.Tests continue to pass for extensions/elytron-security-properties-file/deployment, extensions/smallrye-jwt/deployment, extensions/spring-security/deployment, integration-tests/spring-web.