Reset the TCCL for each test #7106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure the correct TCCL is set if there is a mix of @QuarkusTest and normal tests
|
Are beforeAll/afterAll called more than once in this case? |
|
The are called before and after every @QuarkusTest test class. The issue is that if we don't reset it in between classes and the test suite contains non-quarkus tests (e.g. tests with mocks) then these tests will run with the wrong class loader. This will break Mockito. |
aloubyansky
approved these changes
Feb 10, 2020
|
@stuartwdouglas Thank you, this does fix my mockito error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure the correct TCCL is set if there is a mix
of @QuarkusTest and normal tests