Support for AWS XRay #7165
Merged
Support for AWS XRay #7165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/amazon-lambda
area/core
area/dependencies
|
@sherl0cks @christianThor Please reverify that this works for you still. |
gastaldi
reviewed
Feb 12, 2020
core/deployment/src/main/java/io/quarkus/deployment/steps/NativeImageAutoFeatureStep.java
Outdated
Show resolved
Hide resolved
|
@patriot1burke tested and it works like a charm 👍 |
gsmet
requested changes
Feb 12, 2020
...ntime/src/main/java/io/quarkus/amazon/lambda/xray/graal/LambdaSegmentContextSubtitution.java
Outdated
Show resolved
Hide resolved
extensions/amazon-lambda-xray/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Outdated
Show resolved
Hide resolved
extensions/amazon-lambda-xray/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Outdated
Show resolved
Hide resolved
patriot1burke
force-pushed
the
lambda-trace
branch
from
d4c6abd
to
856a280
Compare
patriot1burke
force-pushed
the
lambda-trace
branch
from
816baa2
to
2951cba
Compare
|
Please rebase this PR |
gastaldi
added
the
triage/needs-rebase
|
@gastaldi I'm such a git idiot...I did a git fetch upstream git rebase -i upstream/master. What did I do wrong? |
improve finish tracing Update docs/src/main/asciidoc/amazon-lambda.adoc Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> Update docs/src/main/asciidoc/amazon-lambda.adoc Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> Update docs/src/main/asciidoc/amazon-lambda.adoc Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> Update docs/src/main/asciidoc/amazon-lambda-http.adoc Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> Update docs/src/main/asciidoc/amazon-lambda-http.adoc Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> Update docs/src/main/asciidoc/amazon-lambda-http.adoc Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> rename Update extensions/amazon-lambda-xray/runtime/src/main/resources/META-INF/quarkus-extension.yaml Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> Update docs/src/main/asciidoc/amazon-lambda-http.adoc Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> moar fixes Update docs/src/main/asciidoc/amazon-lambda.adoc Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> Update extensions/amazon-lambda-xray/runtime/pom.xml Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> Update extensions/amazon-lambda-xray/pom.xml Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> Update extensions/amazon-lambda-xray/deployment/pom.xml Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com>
patriot1burke
force-pushed
the
lambda-trace
branch
from
d61c7c5
to
ca553f6
Compare
|
|
|
I think I was behind.
…On Wed, Feb 12, 2020 at 9:49 PM George Gastaldi ***@***.***> wrote:
git rebase master && git push -f would have been enough :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7165?email_source=notifications&email_token=AAFL53Z4N6RO3XRX6F6YSELRCSYNBA5CNFSM4KT4MJ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELTGBWY#issuecomment-585523419>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFL537L6RELUIBPKTDRZPLRCSYNBANCNFSM4KT4MJ5Q>
.
--
Bill Burke
Red Hat
|
|
Ah then |
gastaldi
removed
the
triage/needs-rebase
gastaldi
approved these changes
Feb 13, 2020
|
@gsmet Think I resolved your concerns. Thanks for editing the docs. |
gsmet
approved these changes
Feb 16, 2020
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for AWS XRay Issue #6785