Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed support for Integrators and ServiceContributors in Hibernate ORM #7208

Merged
merged 3 commits into from
Feb 17, 2020
Merged

Fixed support for Integrators and ServiceContributors in Hibernate ORM #7208

merged 3 commits into from
Feb 17, 2020

Conversation

gastaldi
Copy link
Contributor

Fixes #7189

@gastaldi gastaldi mentioned this pull request Feb 15, 2020
Closed
@gastaldi gastaldi requested a review from Sanne February 15, 2020 00:52
@gastaldi
Add missing @observes in JPAConfig.destroy
6d1eb22 
This triggers the Integrator#disintegrate methods on shutdown
@gastaldi gastaldi requested a review from gsmet February 15, 2020 01:08
@gastaldi gastaldi changed the title Using TCCL while looking for Integrators Fixed support for Integrators and ServiceContributors in Hibernate ORM Feb 15, 2020
@gastaldi
Copy link
Contributor Author

I also added the service files to be hot-reloaded (and they work like a charm!) :)

@gastaldi gastaldi added this to the 1.3.0 milestone Feb 15, 2020
@gastaldi gastaldi added the area/hibernate-orm Hibernate ORM label Feb 15, 2020
@gastaldi
Copy link
Contributor Author

I deleted my previous comment about Hibernate Envers, the project needs to add the hibernate-envers JARs to load it (I thought it was embedded in Hibernate). This PR is good to go 👍

@gastaldi gastaldi requested a review from geoand February 15, 2020 12:42
@geoand
Copy link
Contributor

geoand commented Feb 15, 2020

Seems reasonable to me, but I'm going to leave it to the experts 😉

@gsmet gsmet modified the milestones: 1.3.0.Alpha2, 1.3.0 Feb 17, 2020
@Sanne
Copy link
Member

Sanne commented Feb 17, 2020 •
edited
Loading

looks good 👍 many thanks @gastaldi ! And I appreciate the thourough integration test.

Just have a dumb question regarding the observer?

@Sanne Sanne requested review from Sanne and removed request for gsmet and geoand February 17, 2020 11:08
@Sanne Sanne merged commit 6eb9db1 into quarkusio:master Feb 17, 2020
@gastaldi gastaldi deleted the integrator branch February 18, 2020 14:31
@gsmet
Copy link
Member

gsmet commented Feb 18, 2020

For the record, I backported 6d1eb22 to 1.2.1.Final.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sanne Sanne Sanne approved these changes

Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM
Projects
None yet
Milestone
1.3.0.CR1
Development

Successfully merging this pull request may close these issues.

Function integrate of custom hibernate integrator is not called
4 participants
@gastaldi @geoand @Sanne @gsmet