New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Mutiny support for the mailer service #7211
Conversation
* @return an {@link Uni} indicating when the mails have been sent. The {@link Uni} may fire a failure if the | ||
* emails cannot be sent. | ||
*/ | ||
Uni<Void> send(Mail... mails); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the returned object may give more info instead of Void
? MailResult
perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And what would it contains? Basically it just tells you success or failure which is conveyed using the Uni events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about the message itself but maybe Uni
already handles that
d695133
to
78eb408
Compare
Force pushed to fix the import ordering issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had one small Javadoc comment. Otherwise looks good.
Feel free to fix and merge or ignore and merge :).
extensions/mailer/runtime/src/main/java/io/quarkus/mailer/reactive/ReactiveMailer.java
Outdated
Show resolved
Hide resolved
78eb408
to
8d6f256
Compare
I fixed the small typo and rebased. Let's wait for CI. |
I have difficulty in getting the response code for each email i sent with reactive mailer. return reactiveMailer.send(mail) this is what my return statement looks like after building the mail. The mail object also has a list of recipients. I'm not sure how i can get the response code / status of that email if it was sent or not. Any suggestion is appreciated. |
These changes are backward compatible.
I've also updated:
<empty>
instead ofnull
The template support still returns a
CompletionStage
. It will be covered once #7101 is merged. This would be a breaking change.