Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init gradle integration tests #9852

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Init gradle integration tests #9852

merged 1 commit into from
Jun 15, 2020

Conversation

glefloch
Copy link
Member

@glefloch glefloch commented Jun 8, 2020

This branch initializes integration test for the gradle module.
I moved all functionalTest into the integration test module.

I also added a specific task for native test. Native test can either be run with gradle using:

./gradlew nativeTest

or with maven using:

mvn clean install -Dnative
mvn clean install -Pnative-image

I disable maven compilation for tests as gradle already compiles them. Thus, there is no dependency declaration in integration-tests/gradle/pom.xml.

I also handle List argument type for nativeArgs property in the quarkusBuild task as mentionned in #9536.

@gastaldi, @aloubyansky could you have a look ?

close #9797
close #9536

@boring-cyborg boring-cyborg bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure labels Jun 8, 2020
@aloubyansky
Copy link
Member

It failed on formatting. Otherwise, it looks good to me. Great work @glefloch One thing to be careful about it is dependency caching in our CI. If the pom.xml IT contains no dependencies then if they are not matching those specified in the plugin itself, these dependencies won't be cached in the first step of our CI.

@glefloch glefloch force-pushed the fix/9797 branch 3 times, most recently from cb59c50 to 2e9aef1 Compare June 9, 2020 09:51
aloubyansky
aloubyansky reviewed Jun 9, 2020
View reviewed changes
integration-tests/gradle/gradle.properties
@@ -0,0 +1 @@
version = 999-SNAPSHOT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsmet here is another version property to keep in mind when releasing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's basically another gradle.properties file with version property, in case you have a script for that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for thinking of it :). I'll adjust the release script right away.

aloubyansky
aloubyansky reviewed Jun 9, 2020
View reviewed changes
integration-tests/gradle/src/test/resources/basic-java-native-module/build.gradle Outdated
containerBuild=true
builderImage="quay.io/quarkus/ubi-quarkus-native-image:19.3.1-java11"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only way to configure it? Couldn't we propagate the property from the Maven process?

@glefloch glefloch force-pushed the fix/9797 branch 2 times, most recently from 1090eb3 to b968ce7 Compare June 9, 2020 18:43
aloubyansky referenced this pull request Jun 9, 2020
@mkouba
Clarify the contract of features and capabilities
770dbae 
- introduce enums for core extensions
- validate duplicate features
- deprecate capabilities constants
- only extensions that use hard-coded string constants may be broken
(due to introduction of naming conventions)
@glefloch glefloch force-pushed the fix/9797 branch 16 times, most recently from dee6cee to c9a76ea Compare June 15, 2020 09:39
aloubyansky
aloubyansky approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @glefloch!

@aloubyansky aloubyansky merged commit dfbac89 into quarkusio:master Jun 15, 2020
@gsmet gsmet added this to the 1.6.0 - master milestone Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure
Projects
None yet
Milestone
1.6.0.CR1
Development

Successfully merging this pull request may close these issues.

Add Gradle native TS Restore ability to provide additional command line arguments to native build
3 participants
@glefloch @aloubyansky @gsmet