fix subscription topic #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let mut settings_topic = self.prefix.clone(); | ||
| settings_topic.push_str("/#").unwrap(); | ||
| settings_topic.push_str("/settings/#").unwrap(); |
There was a problem hiding this comment.
I'm confused. The subscription options should have prevented the alive and telemetry messages
There was a problem hiding this comment.
Yeah, we expect to get the settings prefix and subscribe at the upper level because we parse the commands get/set that occur below the settings tree
miniconf/src/mqtt_client/mod.rs
Line 97 in 8be449d
There was a problem hiding this comment.
Not telemetry. That's a different client. But the alive, yes. Maybe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #142