Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typst details to main citation page #1209

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Add Typst details to main citation page #1209

merged 2 commits into from
Jul 2, 2024

Conversation

cwickham
Copy link
Collaborator

@cwickham cwickham commented Jun 27, 2024

Copy link
Contributor

🚀 Deployed on https://deploy-preview-1209.quarto.org

@github-actions github-actions bot temporarily deployed to pull request June 27, 2024 20:37 Inactive
@cwickham
Copy link
Collaborator Author

@cderv This adds the Typst details to the main citation page and calls out that Typst is different at the top. I think it still may be confusing since it isn't clear what parts of the page still apply to Typst (I think none, except "Citation Syntax" and I guess "Bibliography Files" although the supported formats might be different). Is it worth a bigger re-organize to clear that up, or is what is in this PR good enough.

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds the Typst details to the main citation page and calls out that Typst is different at the top. I think it still may be confusing since it isn't clear what parts of the page still apply to Typst (I think none, except "Citation Syntax" and I guess "Bibliography Files" although the supported formats might be different). Is it worth a bigger re-organize to clear that up, or is what is in this PR good enough.

I think it is good enough, but I understand the unclear state. Typst is I think the only format we have supporting citeproc but not defaulting to it. (Maybe we should change that 🤔 )

Probably a reorganization would be helpful. A simple one could be

  • This pages is about Citations. We could bigger sub part to clearly explain the different system that could happen
  • One about Pandoc's citeproc built in system. Almost all content of the current page would be under it
  • One about Format specific system and
    • A subpart about LaTeX system
    • Another about typst own system

The pandoc syntax could be at the top as a common part.

Not urgent though, it works well like this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part could be simplified later when we'll "fix" our missing support for CSL that pandoc's support

This means also that Citation Style will apply.

@cwickham
Copy link
Collaborator Author

cwickham commented Jul 2, 2024

@cderv Thanks for the feedback. I opened quarto-dev/quarto-cli#10204 to track these suggestions and will merge this.

@cwickham cwickham marked this pull request as ready for review July 2, 2024 20:20
@cwickham cwickham merged commit 635f8ec into main Jul 2, 2024
3 checks passed
@cwickham cwickham deleted the issues/9762 branch July 2, 2024 20:20
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Successfully created backport PR for prerelease:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants