Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: add color argument? #23

Closed
kbvernon opened this issue Jan 12, 2023 · 3 comments
Closed

FR: add color argument? #23

kbvernon opened this issue Jan 12, 2023 · 3 comments
Labels
wontfix This will not be worked on

Comments

@kbvernon
Copy link

Hi, thanks for this great Quarto extension. It would be nice if we could add a color argument like so:

{{< fa brands r-project color=steelblue >}}

This has been implemented in https://github.com/schochastics/academicons and seems to work when adding the necessary lines to the lua filter for this extension. I'm happy to submit a PR to do that if you all think this is something worth adding.

Thanks!

@cscheid
Copy link
Contributor

cscheid commented Jan 12, 2023

Is there a reason you prefer this syntax to using a wrapping span on the markdown to adjust the style? We'd like to keep extensions minimal whenever possible.

@kbvernon
Copy link
Author

Do you mean something like this:

[{{< fa brands r-project >}}]{style="color:steelblue"}

I suppose that's an option, just a little verbose. If you all prefer to keep the extension minimal, though, I totally understand.

@cscheid
Copy link
Contributor

cscheid commented Jan 12, 2023

Yes, it is a little verbose, but the reason I'm reluctant to implement your request is that color is only one of the many different CSS changes that someone might want to do, and there's already a mechanism for controlling appearance: CSS. It even enables you to control it globally, by adding a CSS rule that selects all FA icons and changes color. As it stands, adding color would only partially solve the problem, and introduce downstream confusion when people try to use other features.

@cscheid cscheid closed this as completed Jan 12, 2023
@cscheid cscheid added the wontfix This will not be worked on label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants