Fixed the DayOfWeek handling. #2274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System DOW is 0-6 based, where 0 is always Sunday. Cron DOW is 1-7 based, where Sunday is 7. Hence simply casting to int will yield wrong results. When calculating next valid timestamp, it is better to start from the larger offset as the current implementation tends to skip over possible values. Added test cases.
|
Relates to issue: #2273 |
|
|
this would be a huge breaking change - its documented as valid for 1-7 - Sun/Sat. https://www.quartz-scheduler.net/documentation/quartz-3.x/tutorial/crontriggers.html |
This comment was marked as outdated.
This comment was marked as outdated.
|
Ah... I see, this package breaks the CRON "standard"... got it.... |
|
@zorgoz this package's cron is consistent with the java quartz version. So I guess there are just variants of cron, UNIX cron and QUARTZ cron (possibly others), each with subtle differences. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System DOW is 0-6 based, where 0 is always Sunday. Cron DOW is 1-7 based, where Sunday is 7. Hence simply casting to int will yield wrong results.
When calculating next valid timestamp, it is better to start from the larger offset as the current implementation tends to skip over possible values.
Added test cases.