Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the DayOfWeek handling. #2274

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed the DayOfWeek handling. #2274

wants to merge 1 commit into from
+122 −9

Commits on Feb 6, 2024

  1. Fixed the DayOfWeek handling. 

    System DOW is 0-6 based, where 0 is always Sunday. Cron DOW is 1-7 based, where Sunday is 7. Hence simply casting to int will yield wrong results.

When calculating next valid timestamp, it is better to start from the larger offset as the current implementation tends to skip over possible values.

Added test cases.
    @zorgoz
    zorgoz committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    1d19ef3 View commit details
    Browse the repository at this point in the history