Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Client Feature Flags and Sender Prefixmodes in Protocol and UI #309

Closed
wants to merge 2 commits into from

Conversation

justjanne
Copy link
Contributor

In short

  • Transmit in the RegisterClient message the client features as int32
  • Make the current SignalProxy available within of the thread for the
    current user
  • Store the features of a peer in a flag in it
  • Use Peer features to determine how to serialize or deserialize a
    message
  • Add the prefixes to the UI when formatting the sender

Dependencies

Status

  • Implement Protocol
  • Implement UI
  • Implement backwards-compatible (de-)serialization

Rationale

There have been multiple feature requests made asking to support sender modes, and displaying them in the client.

@Nevcairiel
Copy link
Contributor

Can we keep the sender prefixes optional? I never missed them, and don't really want them.

@justjanne
Copy link
Contributor Author

@Nevcairiel Sure, this can easily be made a UI setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants