aii-rci (aii-shellfe --reinstall) exit code is misleading

[itkovian]

If aii-rci encounters an error along the way, the exit code is still 0. For example:

  [root@host ~]# aii-rci machine.domain
  [INFO] remove step for reinstall option.
  echo $?
  [ERROR] host_disable got error (Error CertificateOperationError/4301/Certificate operation cannot be completed: Unable to communicate with CMS (500))
  [INFO] ran remove on 1 nodes
  [INFO] configure step for reinstall option.
  [INFO] DHCP will be updated and restarted if needed
  [ERROR] host_add got error (Error NotFound/4001/DNS zone domain. not found)
  [ERROR] host_mod got error (Error ValidationError/3009/invalid 'password': Password cannot be set on enrolled host.)
  [ERROR] freeipa post_reboot: no OTP for machine.domain
  [INFO] ran configure on 1 nodes
  [INFO] install step for reinstall option.
  [INFO] ran install on 1 nodes
  [root@host ~]# echo $?
  0

[jrha]

@stdweird is aii-rci UGent specific?

[stdweird]

it's used to be, now it's aii-shellfe --reinstall

[jrha]

aha!

[jrha]

Confirmed in to occur in aii-shellfe:

# aii-shellfe --reinstall machine.domain; echo $?
[INFO] remove step for reinstall option.
[ERROR] No node matches machine(.domain)
[INFO] configure step for reinstall option.
[ERROR] No node matches machine(.domain)
[INFO] install step for reinstall option.
[ERROR] No node matches machine(.domain)
0