Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: add GOTOOLCHAIN #2071

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Jun 5, 2024

Changes in go1.21 means the build recipe here was doing the wrong thing. This should restore the expected behavior of using the toolchain present in the container.

@hdonnay hdonnay requested a review from a team as a code owner June 5, 2024 19:56
@hdonnay hdonnay requested review from crozzy and removed request for a team June 5, 2024 19:56
@hdonnay
Copy link
Member Author

hdonnay commented Jun 5, 2024

Cc: @bcaton85

@bcaton85
Copy link

bcaton85 commented Jun 6, 2024

I still get the same (go: no modules specified (see 'go help mod download'))

@hdonnay
Copy link
Member Author

hdonnay commented Jun 6, 2024

Using what command line?

@bcaton85
Copy link

bcaton85 commented Jun 6, 2024

this is ran in a bash shell, if i'm understanding your question correctly

@hdonnay
Copy link
Member Author

hdonnay commented Jun 10, 2024

No, what's the command you're using to build the container?

@bcaton85
Copy link

just podman build .

@hdonnay
Copy link
Member Author

hdonnay commented Jun 10, 2024

Can't reproduce, works on Fedora 40

@bcaton85
Copy link

Yeah i'm on mac, maybe it's a mac issue. TBF i don't think this is a big deal if it doesn't effect development

@hdonnay
Copy link
Member Author

hdonnay commented Jun 11, 2024

This works with "normal" podman but not podman-remote due to SELinux shenanigans:
The go: no modules specified error is reported when there's not a module in the specified directory, but also ends up getting reported when SELinux denies any access to the go.mod file and its metadata.
Adding the relabel flag would make this work uniformly under podman and podman-remote, but is not accepted (AFAICT) by Docker/Moby/BuildKit.

@crozzy This is probably good to go.

Changes in go1.21 means the build recipe here was doing the wrong thing.
This should restore the expected behavior of using the toolchain present
in the container.

Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
Copy link
Member Author

hdonnay commented Jun 24, 2024

/fast-forward

@github-actions github-actions bot merged commit e2fbf19 into quay:main Jun 24, 2024
9 checks passed
@hdonnay hdonnay deleted the chore/dockerfile branch June 24, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants