Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate protobufs in docker #538

Merged
merged 2 commits into from
Apr 4, 2018
Merged

generate protobufs in docker #538

merged 2 commits into from
Apr 4, 2018

Conversation

jzelinskie
Copy link
Contributor

This removes the requirement of the build machine having protobuf and
any extensions installed.

@jzelinskie
api/v3/clairpb: generate protobufs in docker
389b6e9 
This removes the requirement of the build machine having protobuf and
any extensions installed.
@jzelinskie
api/v3/clairpb: regen protobufs
ec5014f
@jzelinskie jzelinskie requested a review from bison April 4, 2018 20:19
bison
bison approved these changes Apr 4, 2018
View reviewed changes
Copy link
Contributor

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@jzelinskie jzelinskie merged commit a5b3e74 into quay:master Apr 4, 2018
@jzelinskie jzelinskie deleted the dockerize-protogen branch April 4, 2018 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bison bison bison approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jzelinskie @bison