Integration of getPlacement() method to Android bridge #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahudzik
force-pushed
the
feature/placements-bridge-android
branch
from
038518b
to
d051d0f
Compare
ljazgar
reviewed
Oct 16, 2020
| @@ -214,6 +214,53 @@ async () => { | |||
|
|
|||
| Returns **[Promise](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Promise)<[array](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Array)<Experience>>** Promise with an array of Experience objects. | |||
|
|
|||
| #### getPlacement | |||
|
|
|||
| Returns Placement for given parameters. | |||
There was a problem hiding this comment.
Method getPlacement should be added to the Typescript definition of API in /src/index.ts
ljazgar
suggested changes
Oct 16, 2020
|
Eventually these changes are included in #8 containing Android, iOS and common (JS, docs) logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.