Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a bridge for getPlacement method #8

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat: Add a bridge for getPlacement method #8

wants to merge 10 commits into from

Conversation

dzmiquido
Copy link

No description provided.

@dzmiquido dzmiquido force-pushed the feature/placements-bridge branch 3 times, most recently from 3d2e0c4 to 8734148 Compare October 20, 2020 09:28
@jahudzik jahudzik mentioned this pull request Oct 22, 2020
Closed
ljazgar
ljazgar reviewed Oct 23, 2020
View reviewed changes
README.md Show resolved Hide resolved
ljazgar
ljazgar reviewed Oct 23, 2020
View reviewed changes
README.md Show resolved Hide resolved
ljazgar
ljazgar reviewed Oct 23, 2020
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
ljazgar
ljazgar suggested changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@ljazgar ljazgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no consistency in data structures passed through layers of the bridge.
Missing documentation and examples of placement callbacks.
Correct working of placement callbacks is doubtful.

@jahudzik jahudzik force-pushed the feature/placements-bridge branch 2 times, most recently from d5f5a81 to 0e64485 Compare November 2, 2020 15:20
ljazgar
ljazgar reviewed Nov 5, 2020
View reviewed changes
BridgeAPI.md Show resolved Hide resolved
ljazgar
ljazgar reviewed Nov 5, 2020
View reviewed changes
src/index.ts Show resolved Hide resolved
ljazgar
ljazgar reviewed Nov 9, 2020
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
ljazgar
ljazgar reviewed Nov 9, 2020
View reviewed changes
README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahudzik jahudzik jahudzik left review comments

@mbalawajdermq mbalawajdermq mbalawajdermq approved these changes

@ljazgar ljazgar ljazgar approved these changes

@hporter hporter Awaiting requested review from hporter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dzmiquido @ljazgar @jahudzik @mbalawajdermq @mbalawajder @hporter