-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a bridge for getPlacement method #8
Open
dzmiquido
wants to merge
10
commits into
master
Choose a base branch
from
feature/placements-bridge
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbalawajdermq
approved these changes
Sep 30, 2020
d850d72
to
e39b395
Compare
3d2e0c4
to
8734148
Compare
8734148
to
d2a7677
Compare
ljazgar
reviewed
Oct 23, 2020
ljazgar
reviewed
Oct 23, 2020
ljazgar
reviewed
Oct 23, 2020
ljazgar
reviewed
Oct 23, 2020
ljazgar
reviewed
Oct 23, 2020
ljazgar
reviewed
Oct 23, 2020
android/src/main/java/com/qubit/reactnative/sdk/QubitSDKModule.java
Outdated
Show resolved
Hide resolved
ljazgar
reviewed
Oct 23, 2020
ljazgar
suggested changes
Oct 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no consistency in data structures passed through layers of the bridge.
Missing documentation and examples of placement callbacks.
Correct working of placement callbacks is doubtful.
d5f5a81
to
0e64485
Compare
0e64485
to
810d5d3
Compare
…instead of object.
ljazgar
reviewed
Nov 5, 2020
ljazgar
reviewed
Nov 5, 2020
ljazgar
reviewed
Nov 9, 2020
ljazgar
reviewed
Nov 9, 2020
ljazgar
reviewed
Nov 9, 2020
android/src/main/java/com/qubit/reactnative/sdk/QubitSDKModule.java
Outdated
Show resolved
Hide resolved
ljazgar
reviewed
Nov 9, 2020
android/src/main/java/com/qubit/reactnative/sdk/QubitSDKModule.java
Outdated
Show resolved
Hide resolved
…returned from getPlacement() function
10b9cb6
to
621e71f
Compare
ljazgar
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.